Add proxy support for SSE transport #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, it appears your tests need |
|
/cc @rmfitzpatrick |
|
ah, and this build failure is because your tests depend on a secure envar ( |
setup.py parses everything in requirements.txt and adds it to install_requires, so httmock was being pulled into the package dependencies even though it's only needed for tests. (Also, it's spelled "tests_require", not "test_requires".)
mpetazzoni
approved these changes
Apr 10, 2019
|
Had to add another change here. It seems your API now returns |
mpetazzoni
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #78 . Also had to fix an issue with the
httmockdependency being pulled into non-test environments. We'd like this to go into a released version, if possible - it's blocking an internal issue and we'd rather not use a git version if we can avoid it.