Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move signing to the right pom.xml #8

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Move signing to the right pom.xml #8

merged 2 commits into from
Jul 10, 2024

Conversation

agoallikmaa
Copy link
Contributor

Signing profiles need to be in the signalflow-client pom.xml as the root project is not marked as parent.

@agoallikmaa agoallikmaa requested review from a team as code owners July 9, 2024 23:44
breedx-splk
breedx-splk approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't seem like increasing the version _should _ strictly be necessary, but shouldn't hurt.

@agoallikmaa agoallikmaa merged commit 741fe69 into signalfx:main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoallikmaa @breedx-splk