Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial beta1 commit, extracted from signalfx-java #1

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

agoallikmaa
Copy link
Contributor

Initial commit for extracting signalflow from signalfx-java repository.

  • New module is named signalflow-client, still published under com.signalfx.public group. Set version to 1.0.0-beta1 for now until a published version is tested.
  • Kept nested structure of the modules, but the root project does not serve as the "parent pom" anymore since no other modules are expected to be public (but would still be possible without refactor if added for additional testing for example).
  • Merged old connection and endpoint source files into signalflow-client module.
  • All new source files are under package com.signalfx.signalflow.client which was previously unused by signalfx-java modules, so there should be no conflicts if for some reason some project includes both old and new modules.

update_version.py Outdated Show resolved Hide resolved
Copy link

@lachmatt lachmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breedx-splk
Copy link
Contributor

Just for historical purposes, here's the list of files which originated above/outside the signalfx-signalflow submodule in signalfx-java:

  • RetryStrategyTest.java
  • RetryStrategy.java
  • RetryHandler.java
  • RetryDefaults.java
  • AbstractHttpReceiverConnection.java
  • SignalFxReceiverEndpoint.java
  • SignalFxEndpoint.java

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring package and import lines, the files match the originals.

@agoallikmaa agoallikmaa merged commit a294b37 into main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants