Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test output #12

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Cleanup test output #12

merged 2 commits into from
Apr 23, 2024

Conversation

pellared
Copy link
Contributor

What

Get rid of a lot of mess emitted to output in tests.

Before

$ go test 
2024/04/23 15:42:04 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-0
2024/04/23 15:42:04 done sending metadata messages
2024/04/23 15:42:04 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-1
2024/04/23 15:42:04 done sending metadata messages
2024/04/23 15:42:04 read err: read tcp 127.0.0.1:39419->127.0.0.1:56330: use of closed network connection
2024/04/23 15:42:04 sending done
2024/04/23 15:42:04 sending done
goroutine profile: total 11
2 @ 0x43e8ae 0x40818d 0x407df7 0x6f8373 0x6f9eba 0x475661
#       0x6f8372        github.com/signalfx/signalflow-client-go/signalflow.bufferMessages[...].func1+0x32      /home/rpajak/repos/signalflow-client-go/signalflow/computation.go:248
#       0x6f9eb9        github.com/signalfx/signalflow-client-go/signalflow.bufferMessages[...]+0x2f9           /home/rpajak/repos/signalflow-client-go/signalflow/computation.go:267

2 @ 0x43e8ae 0x408eff 0x408b32 0x6fa185 0x475661
#       0x6fa184        github.com/signalfx/signalflow-client-go/signalflow.bufferMessages[...]+0x264   /home/rpajak/repos/signalflow-client-go/signalflow/computation.go:272

1 @ 0x433f71 0x46fbdd 0x5548b1 0x5546e5 0x55150b 0x6f8325 0x6f3dfc 0x4fe63b 0x475661
#       0x46fbdc        runtime/pprof.runtime_goroutineProfileWithLabels+0x1c                                           /usr/local/go/src/runtime/mprof.go:1079
#       0x5548b0        runtime/pprof.writeRuntimeProfile+0xb0                                                          /usr/local/go/src/runtime/pprof/pprof.go:774
#       0x5546e4        runtime/pprof.writeGoroutine+0x44                                                               /usr/local/go/src/runtime/pprof/pprof.go:734
#       0x55150a        runtime/pprof.(*Profile).WriteTo+0x14a                                                          /usr/local/go/src/runtime/pprof/pprof.go:369
#       0x6f8324        github.com/signalfx/signalflow-client-go/signalflow.TestFailedConnGoroutineShutdown.func1+0x44  /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:327
#       0x6f3dfb        github.com/signalfx/signalflow-client-go/signalflow.TestFailedConnGoroutineShutdown+0x47b       /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:361
#       0x4fe63a        testing.tRunner+0xfa                                                                            /usr/local/go/src/testing/testing.go:1689

1 @ 0x43e8ae 0x408eff 0x408b12 0x4fe395 0x6ef7d5 0x4fe63b 0x475661
#       0x4fe394        testing.(*T).Parallel+0x214                                                     /usr/local/go/src/testing/testing.go:1483
#       0x6ef7d4        github.com/signalfx/signalflow-client-go/signalflow.TestAuthenticationFlow+0x34 /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:21
#       0x4fe63a        testing.tRunner+0xfa                                                            /usr/local/go/src/testing/testing.go:1689

1 @ 0x43e8ae 0x408eff 0x408b12 0x4fe395 0x6f0098 0x4fe63b 0x475661
#       0x4fe394        testing.(*T).Parallel+0x214                                                     /usr/local/go/src/testing/testing.go:1483
#       0x6f0097        github.com/signalfx/signalflow-client-go/signalflow.TestBasicComputation+0x37   /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:57
#       0x4fe63a        testing.tRunner+0xfa                                                            /usr/local/go/src/testing/testing.go:1689

1 @ 0x43e8ae 0x408eff 0x408b12 0x4fe395 0x6f08d8 0x4fe63b 0x475661
#       0x4fe394        testing.(*T).Parallel+0x214                                                             /usr/local/go/src/testing/testing.go:1483
#       0x6f08d7        github.com/signalfx/signalflow-client-go/signalflow.TestMultipleComputations+0x37       /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:98
#       0x4fe63a        testing.tRunner+0xfa                                                                    /usr/local/go/src/testing/testing.go:1689

1 @ 0x43e8ae 0x408eff 0x408b12 0x4fe395 0x6f14f8 0x4fe63b 0x475661
#       0x4fe394        testing.(*T).Parallel+0x214                                             /usr/local/go/src/testing/testing.go:1483
#       0x6f14f7        github.com/signalfx/signalflow-client-go/signalflow.TestReconnect+0x37  /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:149
#       0x4fe63a        testing.tRunner+0xfa                                                    /usr/local/go/src/testing/testing.go:1689

1 @ 0x43e8ae 0x408eff 0x408b12 0x4fe395 0x6f27d8 0x4fe63b 0x475661
#       0x4fe394        testing.(*T).Parallel+0x214                                                             /usr/local/go/src/testing/testing.go:1483
#       0x6f27d7        github.com/signalfx/signalflow-client-go/signalflow.TestReconnectAfterBackendDown+0x37  /home/rpajak/repos/signalflow-client-go/signalflow/client_test.go:236
#       0x4fe63a        testing.tRunner+0xfa                                                                    /usr/local/go/src/testing/testing.go:1689

1 @ 0x43e8ae 0x408eff 0x408b12 0x4ff50b 0x501657 0x4fe63b 0x501545 0x4fff4b 0x6fb3cc 0x43e45d 0x475661
#       0x4ff50a        testing.(*T).Run+0x3aa          /usr/local/go/src/testing/testing.go:1750
#       0x501656        testing.runTests.func1+0x36     /usr/local/go/src/testing/testing.go:2161
#       0x4fe63a        testing.tRunner+0xfa            /usr/local/go/src/testing/testing.go:1689
#       0x501544        testing.runTests+0x444          /usr/local/go/src/testing/testing.go:2159
#       0x4fff4a        testing.(*M).Run+0x68a          /usr/local/go/src/testing/testing.go:2027
#       0x6fb3cb        main.main+0x16b                 _testmain.go:91
#       0x43e45c        runtime.main+0x29c              /usr/local/go/src/runtime/proc.go:271

2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-0
2024/04/23 15:42:09 Executing SignalFlow program testflow with tsids [] and handle handle-0
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-0
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-0
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program testflow with tsids [fouXI66mp24 USbAoUd6YLw] and handle handle-0
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-0
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [VO80UxiI5Cc cIb2nBY4L4M] and handle handle-0
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-1
2024/04/23 15:42:09 read err: read tcp 127.0.0.1:46325->127.0.0.1:58256: use of closed network connection
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 read err: read tcp 127.0.0.1:36987->127.0.0.1:39992: use of closed network connection
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 read err: read tcp 127.0.0.1:44605->127.0.0.1:58722: use of closed network connection
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-2
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-3
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-4
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-5
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-6
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-7
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-8
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-9
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-10
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-11
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-12
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-13
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-14
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-15
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-16
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-17
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-18
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-19
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-20
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-21
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-22
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-23
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-24
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-25
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-26
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-27
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-28
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-29
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-30
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-31
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-32
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-33
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-34
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-35
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-36
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-37
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-38
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-39
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-40
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-41
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-42
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-43
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-44
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-45
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-46
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-47
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-48
2024/04/23 15:42:09 done sending metadata messages
2024/04/23 15:42:09 read err: read tcp 127.0.0.1:42833->127.0.0.1:52924: use of closed network connection
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:09 sending done
2024/04/23 15:42:10 sending data message
2024/04/23 15:42:10 done sending data message
2024/04/23 15:42:10 read err: read tcp 127.0.0.1:35119->127.0.0.1:52850: use of closed network connection
2024/04/23 15:42:10 sending done
2024/04/23 15:42:11 sending data message
2024/04/23 15:42:11 sending data message
2024/04/23 15:42:11 done sending data message
2024/04/23 15:42:11 done sending data message
2024/04/23 15:42:13 sending data message
2024/04/23 15:42:13 done sending data message
2024/04/23 15:42:13 sending data message
2024/04/23 15:42:13 done sending data message
2024/04/23 15:42:14 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-1
2024/04/23 15:42:14 done sending metadata messages
2024/04/23 15:42:14 [map[token:abcd type:authenticate] map[channel:ch-1 immediate:false maxDelay:0 program:data('cpu.utilization').publish() resolution:0 start:0 stop:0 timezone: type:execute] map[token:abcd type:authenticate] map[channel:ch-2 immediate:false maxDelay:0 program:data('cpu.utilization').publish() resolution:0 start:0 stop:0 timezone: type:execute]]
2024/04/23 15:42:14 read err: read tcp 127.0.0.1:46325->127.0.0.1:58268: use of closed network connection
2024/04/23 15:42:14 sending done
2024/04/23 15:42:15 sending channel end
2024/04/23 15:42:15 sending data message
2024/04/23 15:42:15 done sending data message
2024/04/23 15:42:15 Executing SignalFlow program testflow with tsids [] and handle handle-1
2024/04/23 15:42:15 done sending metadata messages
2024/04/23 15:42:17 sending channel end
2024/04/23 15:42:17 sending data message
2024/04/23 15:42:17 done sending data message
2024/04/23 15:42:17 Executing SignalFlow program testflow with tsids [fouXI66mp24 USbAoUd6YLw] and handle handle-1
2024/04/23 15:42:17 done sending metadata messages
2024/04/23 15:42:19 sending data message
2024/04/23 15:42:19 done sending data message
2024/04/23 15:42:19 sending data message
2024/04/23 15:42:19 done sending data message
2024/04/23 15:42:21 sending channel end
2024/04/23 15:42:21 Executing SignalFlow program data('cpu.utilization').publish() with tsids [] and handle handle-1
2024/04/23 15:42:21 done sending metadata messages
2024/04/23 15:42:21 sending data message
2024/04/23 15:42:21 done sending data message
2024/04/23 15:42:21 read err: read tcp 127.0.0.1:44605->127.0.0.1:39584: use of closed network connection
2024/04/23 15:42:21 sending done
2024/04/23 15:42:23 sending data message
2024/04/23 15:42:23 done sending data message
2024/04/23 15:42:25 sending channel end
PASS
ok      github.com/signalfx/signalflow-client-go/signalflow     21.066s

After

$ go test
PASS
ok      github.com/signalfx/signalflow-client-go/signalflow     19.102s

@pellared pellared marked this pull request as ready for review April 23, 2024 13:46
@pellared pellared requested review from a team as code owners April 23, 2024 13:46
@pellared pellared mentioned this pull request Apr 23, 2024
Closed
@pellared pellared merged commit 43bd996 into main Apr 23, 2024
5 checks passed
@pellared pellared deleted the cleanup-test-output branch April 23, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnbley johnbley johnbley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pellared @johnbley