Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require CLA Assistant GitHub workflow #269

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Require CLA Assistant GitHub workflow #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a20c08
Require CLA Assistant GitHub workflow
pellared Oct 11, 2023
cd3ccc5
Remove EOL
pellared Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .github/workflows/cla.yaml → .github/workflows/cla.yml
View file
Open in desktop
File renamed without changes.
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

## [Unreleased]

### Repository

#### Enhancements

- Require a CLA Assistant GitHub workflow. (#269)
- Update the CLA notice in `CONTRIBUTING.md` template. (#269)

## [1.6.0] - 2023-09-14

### Configuration
Expand Down
3 changes: 3 additions & 0 deletions specification/repository.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ approval is granted, GDI repositories MUST NOT cut a GA release.
- MUST have a default branch named `main`
- MUST NOT allow anyone (including administrators) pushing directly to `main`
- MUST require status checks to pass before merge to `main`
- MUST require a CLA Assistant status check
- MUST require at least one CODEOWNER to approve a PR prior to merge
- MUST require signed commits on `main`
- MUST NOT allow merge commit (squash or rebase merging only)
Expand Down Expand Up @@ -73,6 +74,8 @@ approval is granted, GDI repositories MUST NOT cut a GA release.
to just read access for the `contents` scope.
- MUST only set the absolutely required `permissions` (least privilege)
- MUST set `permissions` for individual `jobs`
- MUST have a CLA Assistant GitHub workflow integrated with [splunk/cla-agreement](https://github.com/splunk/cla-agreement),
e.g. [cla.yml](../.github/workflows/cla.yml)
- SHOULD have Lychee Link Checker GitHub Action configured

### GitHub Applications
Expand Down
7 changes: 3 additions & 4 deletions specification/templates/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ GitHub provides additional documentation on [forking a
repository](https://help.github.com/articles/fork-a-repo/) and [creating a pull
request](https://help.github.com/articles/creating-a-pull-request/).

You may be asked to sign our
[Splunk Contributor License Agreement (CLA)](https://github.com/splunk/cla-agreement/blob/main/CLA.md).

## Finding contributions to work on

Looking at the existing issues is a great way to find something to contribute
Expand All @@ -86,7 +89,3 @@ any 'help wanted' issues is a great place to start.

See the [LICENSE](LICENSE) file for our repository's licensing. We will ask you to
confirm the licensing of your contribution.

### Contributor License Agreement

Before contributing, you must sign the [Splunk Contributor License Agreement (CLA)](https://www.splunk.com/en_us/form/contributions.html).