bridge: When converting panics to errors, check for String too #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-signal
force-pushed
the
jrose/simplify-bridge-macros-part-2
branch
from
58b5256 to
ed2e5bc
Compare
jrose-signal
force-pushed
the
jrose/describe-panic
branch
from
11ebe52 to
53a2364
Compare
jim-signal
approved these changes
Oct 25, 2021
peter-signal
approved these changes
Oct 26, 2021
jrose-signal
force-pushed
the
jrose/describe-panic
branch
from
53a2364 to
8125e89
Compare
|
Spurious failure in the CocoaPod test (trying to fetch a dependency), and it passed before the rebase, so I'm merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rfcs#1389. This
describe_panicfunction is already used in the signal-neon-futures crate but there's not really a common place to factor it out.