This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Log 'Verifying' messages at INFO level #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: WitnessPlugin used `println` to print "Verifying ..." messages forcing the output to show up at the console under all conditions. Solution: Print the same messages using `project.logger` at INFO level, such that "Verifying ..." messages are not printed at all by default, but are printed if `-i/--info` is provided at the command line.
cbeams
added a commit
to cbeams/bisq
that referenced
this pull request
Mar 21, 2018
This performs the same function that the maven-enforcer-plugin did in the pom removed by the previous commit, and also includes a more comprehensive / up-to-date set of dependencies. Note that the gradle-witness jar checked in here is one built from the pull request in signalapp/gradle-witness#26.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: WitnessPlugin used
printlnto print "Verifying ..." messagesforcing the output to show up at the console under all conditions.
Solution: Print the same messages using
project.loggerat INFO level,such that "Verifying ..." messages are not printed at all by default,
but are printed if
-i/--infois provided at the command line.