count packets received when there was no ICE ping

src/apps/relay/prom_server.c

@@ -37,10 +37,11 @@ prom_counter_t *turn_total_sessions;
 
 prom_gauge_t *turn_total_allocations;
 
-// Signal change to add rtt metrics
+// Signal change to add metrics
 prom_counter_t *turn_rtt_client[8];
 prom_counter_t *turn_rtt_peer[8];
 prom_counter_t *turn_rtt_combined[8];
+prom_counter_t *turn_with_no_ping_rcvp;
 
 void start_prometheus_server(void) {
   if (turn_params.prometheus == 0) {
@@ -115,7 +116,7 @@ void start_prometheus_server(void) {
   turn_total_allocations = prom_collector_registry_must_register_metric(
       prom_gauge_new("turn_total_allocations", "Represents current allocations number", 2, total_allocations_labels));
 
-  // Signal change to add rtt metrics
+  // Signal change to add metrics
   // Create round trip time pseudo-histogram metrics
   // values must be kept in sync with observation function below
 
@@ -170,6 +171,9 @@ void start_prometheus_server(void) {
   turn_rtt_combined[7] = prom_collector_registry_must_register_metric(
       prom_counter_new("turn_rtt_combined_more", "Represents combined round trip time of channel", 0, NULL));
 
+  turn_with_no_ping_rcvp = prom_collector_registry_must_register_metric(prom_counter_new(
+      "turn_with_no_ping_rcvp", "Count of packets received for TURN where no ICE ping has been observed", 0, NULL));
+
   promhttp_set_active_collector_registry(NULL);
 
   // some flags appeared first in microhttpd v0.9.53
@@ -288,7 +292,7 @@ int is_ipv6_enabled(void) {
   return ret;
 }
 
-// Signal change to add rtt metrics
+// Signal change to add metrics
 void prom_observe_rtt(prom_counter_t *counter[8], int microseconds) {
   if (microseconds <= 25000) {
     prom_counter_add(counter[0], 1, NULL);
@@ -332,6 +336,12 @@ void prom_observe_rtt_combined(int microseconds) {
   }
 }
 
+void prom_inc_turn_with_no_ping_rcvp(void) {
+  if (turn_params.prometheus == 1) {
+    prom_counter_add(turn_with_no_ping_rcvp, 1, NULL);
+  }
+}
+
 #else
 
 void start_prometheus_server(void) {

src/apps/relay/prom_server.h

@@ -53,10 +53,11 @@ extern prom_counter_t *turn_total_traffic_peer_sentb;
 
 extern prom_gauge_t *turn_total_allocations_number;
 
-// Signal change to add rtt metrics
+// Signal change to add metrics
 extern prom_counter_t *turn_rtt_client[8];
 extern prom_counter_t *turn_rtt_peer[8];
 extern prom_counter_t *turn_rtt_combined[8];
+extern prom_counter_t *turn_with_no_ping_rcvp;
 
 #define TURN_ALLOC_STR_MAX_SIZE (20)
 
@@ -78,11 +79,12 @@ void prom_inc_stun_binding_request(void);
 void prom_inc_stun_binding_response(void);
 void prom_inc_stun_binding_error(void);
 
-// Signal change to add rtt metrics
+// Signal change to add metrics
 void prom_observe_rtt(prom_counter_t *counter[8], int microseconds);
 void prom_observe_rtt_client(int microseconds);
 void prom_observe_rtt_peer(int microseconds);
 void prom_observe_rtt_combined(int microseconds);
+void prom_inc_turn_with_no_ping_rcvp(void);
 
 #else
 

src/server/ns_turn_server.c

@@ -2881,7 +2881,7 @@ static int handle_turn_binding(turn_turnserver *server, ts_ur_super_session *ss,
   return 0;
 }
 
-// Signal change to add rtt metrics
+// Signal change to add metrics
 /////////////// inspect relayed packets, they might be ICE binds ///////////////
 
 static void inspect_binds(turn_turnserver *server, ioa_net_data *in_buffer, turn_permission_info *tinfo, int from_peer,
@@ -2973,6 +2973,12 @@ static void inspect_binds(turn_turnserver *server, ioa_net_data *in_buffer, turn
         tinfo->pings[from_client].ts.tv_sec = 0;
       }
     }
+  } else {
+#if !defined(TURN_NO_PROMETHEUS)
+    if (tinfo->pings[0].lastrttus == 0 && tinfo->pings[1].lastrttus == 0) {
+      prom_inc_turn_with_no_ping_rcvp();
+    }
+#endif
   }
 }