#5876 Switched file decryption priority to be original file extension #5988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type or its file extension. (cherry picked from commit d48965b1d327210771873ac44999edcb6e0ef69c)
3 tasks
|
Thank you very much for looking into this @MarlowBrown |
|
Hey @tomduese. Since I'm just a contributor to this repository it will be when one of the signal devs takes a look at it to merge it into the codebase. Depending on how busy their day is I can't give you a concrete timeline. All that I hope for is within a month. |
|
Hey @MarlowBrown. This is a deceptively simple change, and before we take it I'll need to do a thorough evaluation of what the upstream effects would be. This method is very explicit in its preference order, so while it may be safe to change this I'd want to be sure it won't inadvertently break other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This PR
fixes #5876by changing the file decryption priority to be the files original extension instead of the detected files mime type.However I do see some value in decrypting the file as its mime type to see the raw file; I think losing the ability to send the file to the respective application its used for comes second to that. Perhaps in the future the UI/UX will be redesigned to accommodate path viewing the raw file and being able to use the original files extension.
FPLSignal.mov