Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpm and appimage builds #7007

Closed
wants to merge 1 commit into from
Closed

Conversation

ralvarezt
Copy link

First time contributor checklist:

Contributor checklist:

  • [X ] My contribution is not related to translations.
  • [X ] My commits are in nice logical chunks with good commit messages
  • [X ] My changes are rebased on the latest main branch
  • [X ] A npm run ready run passes successfully (more about tests here)
  • [X ] My changes are ready to be shipped to users

Description

Provide rpm and appimage builds without breaking deb builds.
Fixes #1758 and other rpm-related issues.

@ayumi-signal
Copy link
Contributor

Thanks for your contribution. We are not ready to add these platforms yet. Please consult with us before opening pull requests which affect the release flow.

@ralvarezt
Copy link
Author

What do you mean you're not ready yet? This change has been tested in a Fedora installation without issues.

@ayumi-signal
Copy link
Contributor

Regarding supported platforms, we validate releases on all supported OS'es (MacOS, Windows, Ubuntu) using automated and manual testing. Furthermore our build pipeline must be updated.

By specifically including Fedora then it is an implicit guarantee that the app is going to work as expected.

We want to make signal as universally available as possible, but we currently don't have developer bandwidth to do these steps, and when we're ready then we will take these steps.

@ralvarezt
Copy link
Author

ralvarezt commented Sep 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Please provide a distribution-neutral AppImage for Linux
2 participants