Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX, #6928] bug/transparent-png-does-not-work-#6928 #6947

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FIX, #6928] bug/transparent-png-does-not-work-#6928 #6947

wants to merge 2 commits into from

Commits on Jul 29, 2024

  1. Add some tests demonstrating image-related behaviours. 

    [signalapp#6928] Transparent Png Doesn't Work (Even With Files)

Add a failing test to show that in some cases uploading a png file results in a jpg being
produced.

[signalapp#6881] File size increase when sending images

Add a passing test that automates the example written in the issue,
where a file's size increases after uploading.

Run with:

  npm run generate && npm run test-electron -- --grep="image processing"

It does add an extra devDependency, hope that's okay. It's for
inspecting jpeg images.
    @ben-biddington
    ben-biddington committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    06358ab View commit details
    Browse the repository at this point in the history

  2. [signalapp#6928] Preserve PNG transparency 

    This does make the test pass, not sure if there are wider implications.

Is there a reason png files need to be converted to jpeg sometimes?
    @ben-biddington
    ben-biddington committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    562d35e View commit details
    Browse the repository at this point in the history