[FIX, #6852] bug/missing buttons on zoomed in pictures #6852 #6943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
main
branchnpm run ready
run passes successfully (more about tests here)Description
Resolves the issue described by Missing buttons on zoomed-in pictures. The change to set the opacity to 0 was introduced in 7dca544 (Oct 13, 2021), so has been around for a long time.
Before
This picture show the problem: there are no controls in the top right corner.
After
With the proposed change you can see that the zoomed-in view now has the conversation name and controls visible.
The
__container--zoom
class is only used in this one place.There are two commits here, the first is a new failing test, and the second is the change that makes the test pass.
I also have a general question about getting back the ids of messages and conversations. Having ids of things available would make UI selection easier. I looked through the mock server and other tests but can't work out how to do it.