Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX, #6852] bug/missing buttons on zoomed in pictures #6852 #6943

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ben-biddington
Copy link
Contributor

@ben-biddington ben-biddington commented Jul 19, 2024

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A npm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Resolves the issue described by Missing buttons on zoomed-in pictures. The change to set the opacity to 0 was introduced in 7dca544 (Oct 13, 2021), so has been around for a long time.

Before

This picture show the problem: there are no controls in the top right corner.

before

After

With the proposed change you can see that the zoomed-in view now has the conversation name and controls visible.

after

The __container--zoom class is only used in this one place.

There are two commits here, the first is a new failing test, and the second is the change that makes the test pass.

I also have a general question about getting back the ids of messages and conversations. Having ids of things available would make UI selection easier. I looked through the mock server and other tests but can't work out how to do it.

@ben-biddington ben-biddington changed the title [FIX] bug/missing buttons on zoomed in pictures #6852 [FIX, #6852] bug/missing buttons on zoomed in pictures #6852 Jul 19, 2024
@ben-biddington ben-biddington marked this pull request as draft July 19, 2024 04:35
@ben-biddington
Copy link
Contributor Author

Converted to draft because I am adding a test

@ben-biddington ben-biddington force-pushed the bug/missing-buttons-on-zoomed-in-pictures-#6852 branch 2 times, most recently from f59d526 to 8dadc90 Compare July 21, 2024 05:28
@ben-biddington ben-biddington marked this pull request as ready for review July 21, 2024 05:31
@ben-biddington ben-biddington force-pushed the bug/missing-buttons-on-zoomed-in-pictures-#6852 branch from 8dadc90 to 37385fb Compare July 21, 2024 05:33
@trevor-signal trevor-signal self-requested a review July 22, 2024 13:52
Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant