Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow in AttachmentSection #6728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

anddea
Copy link

@anddea anddea commented Dec 22, 2023

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages.
  • My changes are rebased on the latest main branch.
  • A yarn ready run passes successfully (more about tests here).
  • My changes are ready to be shipped to users.

Description

This commit will truncate long titles of documents in attachment section.
To reproduce, just upload a document with a long title and open attachments, then resize window.

Screenshots

Before
1

After
2

@ayumi-signal ayumi-signal self-assigned this Dec 22, 2023
@ayumi-signal
Copy link
Contributor

@anddea Hello, thanks for your contribution. It looks like you've made a design/frontend related change, however it's not clear exactly what the change affects.

  1. Can you provide an issue # and/or Reproduction steps/Test plan; and
  2. Provide screenshots showing before/after the change?

Additionally, it looks like the Contributor License Agreement hasn't been signed. Before we can merge this commit you would need to sign that.

@anddea
Copy link
Author

anddea commented Dec 23, 2023

Hello, @ayumi-signal. I added screenshots to original message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants