Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to pass to electron --disable-features values #6627

Closed
wants to merge 0 commits into from

Conversation

yaslama
Copy link
Contributor

@yaslama yaslama commented Oct 2, 2023

Right now, HardwareMediaKeyHandling is the only disabled value and all other disabled values are ignored.

This flag is needed when using Wayland due to the bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1356014 In order to have a non blurry app, WaylandFractionalScaleV1 has to be added to the disabled features

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

I didn't find this exact issue in this project but any app using electron - and also chromium - needs this parameter when the
scale is 200% in Gnome/Wayland

I launched the app and verified that it's not blurry when I added the following parameters in the command line:
--enable-features=WaylandWindowDecorations --ozone-platform-hint=auto --disable-features=WaylandFractionalScaleV1

@indutny-signal
Copy link
Contributor

Hello! This PR was actually merged internally. Sorry for the confusion. The force pushes happened because I made mistakes when trying to run yarn format on your work. Thanks for the submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants