Modernize "chat session refreshed" modal #6531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerbirds
force-pushed
the
pr-chat-session-modal
branch
from
e714b66
to
906d42b
Compare
* Hard-coded background colors were removed * Buttons were moved to Modal's footer * Use <Button> instead of HTML <button>, removed the old buttons CSS
hackerbirds
force-pushed
the
pr-chat-session-modal
branch
from
906d42b
to
9b0ff43
Compare
|
Hi, this PR was rebased for v6.29.0.beta-1. |
scottnonnenberg-signal
requested review from
trevor-signal
and removed request for
josh-signal
|
Thanks @hackerbirds! Really appreciate your work & attention to detail. We’ve merged this internally, and it will be released in our next beta family. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
This is a rare error so it went unnoticed for a while, but the hard-coded background colors on the "chat session refreshed" modal clashed with the
<Modal>'s background colors. I removed the CSS that did that, and I took this opportunity to also update the footer; first by moving the buttons into the<Modal>'s footer as it should, but also by changing the old<button>+ their CSS with the more appropriate<Button>type. Those button changes were inspired from DeliveryIssueDialog.tsx which renders fine. Bonus, it shaved off a few lines from_modules.scss.BEFORE:
AFTER:
