forked from justeattakeaway/pie
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(pie-monorepo): DSW-1823 test pr templates
- Loading branch information
Showing
3 changed files
with
53 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
## Describe your changes (can list changeset entries if preferable) | ||
|
||
|
||
## Author Checklist (complete before requesting a review) | ||
- [ ] I have performed a self-review of my code | ||
- [ ] If it is a core feature, I have added thorough tests | ||
- [ ] If it is a `PIE Docs` change, I have reviewed the Docs site preview | ||
- [ ] If it is a component change, I have reviewed the Storybook preview | ||
- [ ] If there are visual test updates, I have reviewed them properly before approving | ||
|
||
## Reviewer checklists (complete before approving) | ||
### Reviewer 1 | ||
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview | ||
- [ ] If there are visual test updates, I have reviewed them | ||
|
||
### Reviewer 2 | ||
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview | ||
- [ ] If there are visual test updates, I have reviewed them |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
## Describe your changes (can list changeset entries if preferable) | ||
|
||
|
||
## Author Checklist (complete before requesting a review) | ||
- [ ] I have performed a self-review of my code | ||
- [ ] I have added Playwright component tests or ensured they exist for affected code. | ||
- [ ] I have added Playwright Viual tests or ensured they exist for affected code. | ||
- [ ] I have reviewed the Storybook preview | ||
- [ ] I have reviewed visual test updates properly before approving | ||
- [ ] If changes will affect consumers of the package, I have created a changeset entry. | ||
- [ ] If a changeset file has been created, I have used the `/snapit` functionality to test my changes in a consuming application. | ||
|
||
## Reviewer checklists (complete before approving) | ||
### Reviewer 1 | ||
- [ ] If there are visual test updates, I have reviewed them | ||
|
||
### Reviewer 2 | ||
- [ ] If there are visual test updates, I have reviewed them |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
## Describe your changes (can list changeset entries if preferable) | ||
|
||
|
||
## Author Checklist (complete before requesting a review) | ||
- [ ] I have performed a self-review of my code | ||
- [ ] I have added Playwright component tests | ||
- [ ] I have added Playwright Viual tests and created a project in Percy | ||
- [ ] I have reviewed the Storybook preview | ||
- [ ] I have reviewed visual test updates properly before approving | ||
- [ ] I have created a changeset entry. | ||
|
||
## Reviewer checklists (complete before approving) | ||
### Reviewer 1 | ||
- [ ] If there are visual test updates, I have reviewed them | ||
|
||
### Reviewer 2 | ||
- [ ] If there are visual test updates, I have reviewed them |