fix(bmap): reset internal state before writing #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before writing a new image file, we need to reset the internal state of the bmap writing algorithm. Otherwise subsequent writes do not start with a clean state. While fixing this, we also shrink the state by making the number of written blocks a local variable (it can be trivially computed from the bytes written and the blocksize). Signed-off-by: Felix Moessbauer <[email protected]>
chombourger
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before writing a new image file, we need to reset the internal state of the bmap writing algorithm. Otherwise subsequent writes do not start with a clean state. While fixing this, we also shink the state by making the number of written blocks a local variable (it can be trivially computed from the bytes written and the blocksize).
Hopefully that's the last fix for the bmap algorithm. Unfortunately all that is not easy to test, because many of the issues only show up on big and more complex images.