Added algorithm to auto-parse .bmap 2.0 files and write accordingly #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos to both of you for implementing this very much desired feature |
|
I forgot about the code formatting guidelines... sorry. |
|
No worries, we have these CI checks to catch such minor issues 😀 |
|
Please make sure to squash your 2 commits together (we'd like to avoid having a first commit and a second commit fixing the first) |
kergos
force-pushed
the
add-bmap2.0-functionality
branch
from
99340b7
to
c6a4908
Compare
chombourger
reviewed
Aug 14, 2023
In `client.py` a bmap file in the same folder as the image supplied with `mtda-cli storage write image.wic` is searched. If there is no .bmap or the parsing of the .bmap file goes wrong, the image is written just like before. The algorithm was tested with 2 different images with holes. Each currently supported format (raw, bz, gz, xz and zst) was tested for both of them and successfully flashed to a storage. Signed-off-by: Manuel Josef Matzinger <[email protected]>
kergos
force-pushed
the
add-bmap2.0-functionality
branch
from
c6a4908
to
5c89f5b
Compare
|
Looks good to me |
chombourger
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses issue #15.
Since the class
BmapBdevCopyfrom thebmaptoolspackage expects a file stream to work properly and in this implementation we work with chunks of data, a custom algorithm for writing bmap 2.0 images is created.In
client.pya bmap file in the same folder as the image supplied withmtda-cli storage write image.wicis searched. If there is no .bmap or the parsing of the .bmap file goes wrong, the image is written just like before. The algorithm was tested with 2 different images with holes. Each currently supported format (raw, bz, gz, xz and zst) was used for both of them and successfully flashed to a storage.Credits go also to @fmoessbauer for supporting this endeavor.