Add support to run MTDA web frontend behind reverse proxy #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the material icons could not be found because the subpath /assets was added twice. Signed-off-by: Felix Moessbauer <[email protected]>
This change imports the js dependencies from relative paths instead of absolute ones. By that, running behind a reverse proxy with a URI rewrite becomes possible. Signed-off-by: Felix Moessbauer <[email protected]>
This change ensures that all resources are references relative to the current URI. By that, the whole MTDA web frontend can be served below a subpath. This is required to support use-cases where multiple MTDA devices are served by a single nginx reverse proxy in a single web page. This approach can be used to serve a whole testing network via a single IP entrypoint and without giving the users IP access to the testing network itself. To make the socket.io communication work, we further set the path component of the current URI when connecting to the ws server. Signed-off-by: Felix Moessbauer <[email protected]>
chombourger
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Excellent work @fmoessbauer - thank you so much for your contribution
|
@fmoessbauer I think the nginx config needs to be licensed. see here: https://github.com/siemens/mtda/blob/master/.reuse/dep5 |
Ok, will update the commit. |
This adds an example nginx configuration file to access multiple mtda devices via a reverse proxy. By that, users can access a set of mtda devices via a single web-frontend and without having IP access to each individual MTDA device. Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/make-reverse-proxy-compatible
branch
from
b219263
to
f4a079f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that all resources are references relative to the
current URI. By that, the whole MTDA web frontend can be served below a
subpath. This is required to support use-cases where multiple MTDA
devices are served by a single nginx reverse proxy in a single web page.
This approach can be used to serve a whole testing network via a single
IP entrypoint and without giving the users IP access to the testing
network itself.
To make the socket.io communication work, we further set the path
component of the current URI when connecting to the ws server.