fixing the skipped & dropped stats counting

siemens · Oct 22, 2021 · 8811f4b · 8811f4b
1 parent e0d0f5d
commit 8811f4b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,13 +4,10 @@ Notable changes will be documented here
 
 ## 0.9.28
 
-- sample UI:
-  - showing the `/stats` results
-
-## 0.9.27
-
 - link-checker-service
   - a simple `/stats` endpoint
+- sample UI:
+  - showing the `/stats` results
 
 ## 0.9.26
 

diff --git a/infrastructure/url_checker.go b/infrastructure/url_checker.go
@@ -335,9 +335,10 @@ func onCheckResult(res *URLCheckResult) {
 	case Broken:
 		s.OnLinkBroken()
 	case Dropped:
-		s.OnLinkDropped()
+		// handled in the drop handler
 	case Skipped:
-		s.OnLinkSkipped()
+		// handled in an upper layer
+		break
 	}
 }
 
@@ -430,6 +431,7 @@ func normalizeAddressOf(input string) string {
 func (c *URLCheckerClient) checkURL(ctx context.Context, urlToCheck string, client *resty.Client) (*URLCheckResult, bool) {
 	select {
 	case <-ctx.Done():
+		GlobalStats().OnLinkDropped()
 		return &URLCheckResult{
 			Status:                Dropped,
 			Code:                  CustomHTTPErrorCode,

diff --git a/server/server.go b/server/server.go
@@ -350,6 +350,7 @@ func translateCheckerTrace(trace []infrastructure.URLCheckerPluginTrace) []URLCh
 }
 
 func urlBlacklisted(url URLRequest) URLStatusResponse {
+	infrastructure.GlobalStats().OnLinkSkipped()
 	return URLStatusResponse{
 		URLRequest:            url,
 		HTTPStatus:            infrastructure.CustomHTTPErrorCode,