Skip to content

Commit

Permalink
w83627hf: Solely depend on pci vendor and station id
Browse files Browse the repository at this point in the history
The host bridge device id varies over the different configurations of
the BX-56A and BX-59A. Only filter intel based devices and then depend
on the station id.

Signed-off-by: Tobias Schaffner <[email protected]>
Signed-off-by: Jan Kiszka <[email protected]>
  • Loading branch information
TobiasSchaffner authored and jan-kiszka committed May 17, 2024
1 parent b0ec245 commit 75edea9
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions drivers/watchdog/w83627hf_wdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@
#include "simatic.h"
#include "utils.h"

/* Use the host bridge device found on the BX-59A to limit probing to Intel
* based machines that may be a BX59A; technically we do not use/need PCI
* for this driver but only port I/Os */
#define PCI_DEVICE_ID_INTEL_HOST_BRIDGE 0xa700

#define WDT_EFER (wdt_io+0) /* Extended Function Enable Registers */
#define WDT_EFIR (wdt_io+0) /* Extended Function Index Register
(same as EFER) */
Expand Down Expand Up @@ -198,12 +193,12 @@ static int wdt_set_time(unsigned int timeout)
}

static EFI_STATUS init(EFI_PCI_IO *pci_io, UINT16 pci_vendor_id,
UINT16 pci_device_id, UINTN timeout)
UINT16 __attribute__((unused)) pci_device_id,
UINTN timeout)
{
int chip, ret;

if (!pci_io || pci_vendor_id != PCI_VENDOR_ID_INTEL ||
pci_device_id != PCI_DEVICE_ID_INTEL_HOST_BRIDGE) {
if (!pci_io || pci_vendor_id != PCI_VENDOR_ID_INTEL) {
return EFI_UNSUPPORTED;
}

Expand Down

0 comments on commit 75edea9

Please sign in to comment.