Skip to content

Commit

Permalink
style: downgrade eslint for now
Browse files Browse the repository at this point in the history
  • Loading branch information
aniravi24 committed Apr 18, 2024
1 parent ed1b48c commit f522db1
Show file tree
Hide file tree
Showing 16 changed files with 233 additions and 207 deletions.
8 changes: 4 additions & 4 deletions .changeset/config.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
"access": "public",
"baseBranch": "main",
"changelog": [
"@changesets/changelog-github",
{ "repo": "sidetracklabs/sidetrack" }
],
"commit": false,
"fixed": [["sidetrack", "@sidetrack/client-prisma"]],
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
"ignore": [],
"updateInternalDependencies": "patch"
}
28 changes: 14 additions & 14 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,30 +12,18 @@
}
},
{
"files": ["*.ts", "*.tsx", "*.mts"],
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:@typescript-eslint/strict"
],
"files": ["*.ts", "*.tsx", "*.mts"],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": ["./tsconfig.json"]
},
"plugins": ["simple-import-sort", "import", "typescript-sort-keys"],
"rules": {
"@typescript-eslint/no-non-null-assertion": "off", // this rule just isn't useful for us right now
"@typescript-eslint/no-unnecessary-condition": "off", // this rule just isn't useful for us right now
"@typescript-eslint/restrict-plus-operands": "off", // this rule just isn't useful for us right now
"@typescript-eslint/restrict-template-expressions": "off", // this rule just isn't useful for us right now
// "@typescript-eslint/promise-function-async": "error",
"@typescript-eslint/sort-type-constituents": "error",
"import/first": "error",
"import/newline-after-import": "error",
"import/no-duplicates": "error",
"simple-import-sort/exports": "error",
"simple-import-sort/imports": "error",
"typescript-sort-keys/interface": "error",
"@typescript-eslint/ban-ts-comment": [
"error",
{
Expand All @@ -49,20 +37,32 @@
"interface"
],
"@typescript-eslint/consistent-type-imports": "off",
"@typescript-eslint/no-non-null-assertion": "off", // this rule just isn't useful for us right now
"@typescript-eslint/no-throw-literal": "off",
"@typescript-eslint/no-unnecessary-condition": "off", // this rule just isn't useful for us right now
// This is already managed by typescript itself
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/restrict-plus-operands": "off", // this rule just isn't useful for us right now
"@typescript-eslint/restrict-template-expressions": "off", // this rule just isn't useful for us right now
// "@typescript-eslint/promise-function-async": "error",
"@typescript-eslint/sort-type-constituents": "error",
"@typescript-eslint/switch-exhaustiveness-check": "error",
"@typescript-eslint/unbound-method": "off",
"eqeqeq": "error",
"import/first": "error",
"import/newline-after-import": "error",
"import/no-duplicates": "error",
"no-extra-bind": "error",
"no-fallthrough": "error",
"no-invalid-regexp": "error",
"no-invalid-this": "error",
"no-return-assign": "error",
"no-self-compare": "error",
"no-useless-concat": "error",
"no-useless-return": "error"
"no-useless-return": "error",
"simple-import-sort/exports": "error",
"simple-import-sort/imports": "error",
"typescript-sort-keys/interface": "error"
}
}
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@typescript-eslint/parser": "7.7.0",
"commitizen": "4.3.0",
"cz-git": "1.9.1",
"eslint": "9.0.0",
"eslint": "8.57.0",
"eslint-config-prettier": "9.1.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-simple-import-sort": "12.1.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/client-prisma/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"extends": "../../tsconfig.json",
"include": ["*.ts", "*.mts", "src", "test"],
"exclude": ["dist", "test/prisma"],
"compilerOptions": {
"declaration": false,
"declarationMap": false
}
},
"exclude": ["dist", "test/prisma"],
"extends": "../../tsconfig.json",
"include": ["*.ts", "*.mts", "src", "test"]
}
2 changes: 1 addition & 1 deletion packages/client-prisma/typedoc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": ["../../typedoc.base.json"],
"entryPoints": ["src/index.ts"],
"extends": ["../../typedoc.base.json"],
// Only used by docs-all script
"out": "./docs"
}
3 changes: 2 additions & 1 deletion packages/pg-migrate/src/db.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,9 @@ ${err}
close: async () => {
await beforeCloseListeners.reduce(
(promise, listener) =>
// eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
// eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-call
promise
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
.then(listener)
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access
.catch((err: any) => logger.error(err.stack || err)),
Expand Down
6 changes: 3 additions & 3 deletions packages/pg-migrate/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ export const createTransformer =
v === undefined
? ""
: typeof v === "string" ||
(typeof v === "object" && v !== null && "name" in v)
? literal(v)
: String(escapeValue(v)),
(typeof v === "object" && v !== null && "name" in v)
? literal(v)
: String(escapeValue(v)),
);
}, s);

Expand Down
8 changes: 4 additions & 4 deletions packages/pg-migrate/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"extends": "../../tsconfig.json",
"include": ["*.ts", "*.mts", "src", "test"],
"exclude": ["dist"],
"compilerOptions": {
"declaration": false,
"declarationMap": false
}
},
"exclude": ["dist"],
"extends": "../../tsconfig.json",
"include": ["*.ts", "*.mts", "src", "test"]
}
4 changes: 2 additions & 2 deletions packages/pg-migrate/typedoc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": ["../../typedoc.base.json"],
"entryPoints": []
"entryPoints": [],
"extends": ["../../typedoc.base.json"]
}
8 changes: 4 additions & 4 deletions packages/sidetrack/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"extends": "../../tsconfig.json",
"include": ["*.ts", "*.mts", "src", "test"],
"exclude": ["dist"],
"compilerOptions": {
"declaration": false,
"declarationMap": false
}
},
"exclude": ["dist"],
"extends": "../../tsconfig.json",
"include": ["*.ts", "*.mts", "src", "test"]
}
8 changes: 4 additions & 4 deletions packages/sidetrack/typedoc.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": ["../../typedoc.base.json"],
"entryPoints": ["src/index.ts", "src/effect.ts"],
// Only used by docs-all script
"out": "./docs",
"excludeInternal": true,
"excludePrivate": true,
"excludeInternal": true
"extends": ["../../typedoc.base.json"],
// Only used by docs-all script
"out": "./docs"
}
Loading

0 comments on commit f522db1

Please sign in to comment.