feat: rework iscsi-tools #577
Merged
+14
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Jan 5, 2025
Rework `iscsi-tools` extensions tested based on siderolabs/extensions#577 Signed-off-by: Noel Georgi <[email protected]>
smira
reviewed
Jan 8, 2025
|
Please test this with longhorn... |
already here siderolabs/talos#10087 |
|
And Synology CSI, which frankly needs docs revisions. I have a Synology NAS I can use to help test, if necessary. |
this is not something we can test here, so if possible that would be great |
frezbo
force-pushed
the
feat/rework-iscsi
branch
3 times, most recently
from
1be4788 to
4b6f1f1
Compare
smira
reviewed
Jan 20, 2025
smira
approved these changes
Jan 20, 2025
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not needed when using as a client. * Drop `isns` since we never ran `isns` daemon * Drop `iscsid-wrapper` since Talos now manages `iqn`, ref: siderolabs/talos#10162 Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
feat/rework-iscsi
branch
from
4b6f1f1 to
4a2e536
Compare
|
/m |
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Jan 20, 2025
Rework `iscsi-tools` extensions tested based on siderolabs/extensions#577 Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Jan 20, 2025
Rework `iscsi-tools` extensions tested based on siderolabs/extensions#577 Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Jan 20, 2025
Rework `iscsi-tools` extensions tested based on siderolabs/extensions#577 Signed-off-by: Noel Georgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tgtdis only needed if exposingiSCSItargets from the host, not needed when using as a client.isnssince we never ranisnsdaemoniscsid-wrappersince Talos now managesiqn, ref: feat: generate iqn and nqn files. talos#10162