Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marginalizing gamma_in distributions of individual systems #29

Merged
merged 25 commits into from
Feb 6, 2024

Conversation

williyamshoe
Copy link
Collaborator

@williyamshoe williyamshoe commented Jan 23, 2024

This PR:

  • adds a feature to marginalize gamma_in distributions of individual systems at a population level.
  • adds @ajshajib and @williyamshoe as contributors in the AUTHORS.rst.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ae7cd8) 99.38% compared to head (cc16c56) 99.38%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          44       44           
  Lines        2262     2270    +8     
=======================================
+ Hits         2248     2256    +8     
  Misses         14       14           
Files Coverage Δ
hierarc/LensPosterior/kin_constraints_composite.py 100.00% <100.00%> (ø)
hierarc/Likelihood/cosmo_likelihood.py 92.55% <ø> (ø)
hierarc/Likelihood/hierarchy_likelihood.py 98.32% <100.00%> (+0.06%) ⬆️
hierarc/Sampling/ParamManager/lens_param.py 100.00% <100.00%> (ø)
hierarc/Sampling/ParamManager/param_manager.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@williyamshoe
Copy link
Collaborator Author

From the code report, the tests fail because "Support for nose tests is deprecated". Likely due to version differences with current version of pytest (v8.0.0). Locally, my tests run fine (v7.4.3). I am unsure what the solution is. We can rewrite all our tests to conform to the new pytest version, or just use an older version.

@sibirrer
Copy link
Owner

From the code report, the tests fail because "Support for nose tests is deprecated". Likely due to version differences with current version of pytest (v8.0.0). Locally, my tests run fine (v7.4.3). I am unsure what the solution is. We can rewrite all our tests to conform to the new pytest version, or just use an older version.

I just pushed a change hopefully making the deprecations/failures go away. Hope this works if you re-sync the main branch into your PR

@sibirrer sibirrer requested a review from ajshajib January 30, 2024 21:03
@ajshajib ajshajib merged commit 66b9645 into sibirrer:main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants