Tweaks

Benchmarks.App/Benchmark.cs

@@ -8,9 +8,6 @@ internal record Benchmark(
 
 internal static partial class BenchmarkExtensions
 {
-    internal static bool HasSimilarNameAndDescription(this Benchmark benchmark) =>
-        benchmark.Description.ReplaceWhitespace(string.Empty) == benchmark.Name;
-
     internal static Table Markup(this Benchmark benchmark)
     {
         var table = new Table
@@ -42,10 +39,4 @@ internal static Table Markup(this Benchmark benchmark)
 
         return table;
     }
-
-    [GeneratedRegex(@"\s+")]
-    private static partial Regex WhitespaceRegex();
-    private static readonly Regex MatchWhitespace = WhitespaceRegex();
-    private static string ReplaceWhitespace(this string input, string replacement) =>
-        MatchWhitespace.Replace(input, replacement);
 }

Benchmarks.App/BenchmarkRunner.cs

@@ -4,7 +4,7 @@ internal static class BenchmarkRunner
 {
     public static IEnumerable<Summary> RunAndBuildSummaries()
     {
-        var args = new[] { "--filter", $"Benchmarks*" };
+        var args = new[] { "--filter", "Benchmarks*" };
         var types = Reflection.GetBenchmarkTypes().ToArray();
 
         return RunAndBuildSummaries(types, args);
@@ -21,7 +21,6 @@ public static IEnumerable<Summary> RunAndBuildSummaries(BenchmarkSettings settin
 
     public static IEnumerable<Summary> RunAndBuildSummaries(Type[] benchmarkTypes, string[] args)
     {
-
         AnsiConsole.Cursor.Move(CursorDirection.Up, 1);
 
         Console.SetOut(TextWriter.Null);
@@ -45,13 +44,10 @@ public static IEnumerable<Summary> RunBenchmarks(Type[] types, string[] args) =>
 
     internal static bool IsDebugConfiguration(bool warnRatherThanFail = false)
     {
-        // ReSharper disable once JoinDeclarationAndInitializer
-        bool debug;
+        var debug = false;
 
 #if DEBUG
         debug = true;
-#else
-        debug = false;
 #endif
 
         if (!debug)

Benchmarks.App/Commands/BenchmarkCommand.cs

@@ -2,10 +2,7 @@
 
 internal sealed class BenchmarkCommand : Command<BenchmarkSettings>
 {
-    [SuppressMessage("ReSharper", "RedundantNullableFlowAttribute")]
-    public override int Execute(
-        [NotNull] CommandContext context,
-        [NotNull] BenchmarkSettings settings)
+    public override int Execute(CommandContext context, BenchmarkSettings settings)
     {
         if (BenchmarkRunner.IsDebugConfiguration(settings.Debug))
         {

Benchmarks.App/Commands/BenchmarkSettings.cs

@@ -12,7 +12,12 @@ internal sealed class BenchmarkSettings : CommandSettings
 
     public override ValidationResult Validate()
     {
-        if (!Reflection.GetBenchmarkTypes().Any(type => type.Name == Name))
+        if (string.IsNullOrWhiteSpace(Name))
+        {
+            return ValidationResult.Error($"Benchmark name required");
+        }
+
+        if (Reflection.GetBenchmarkTypes().All(type => type.Name != Name))
         {
             return ValidationResult.Error($"Benchmark not found {Name}");
         }

Benchmarks.App/Commands/InfoCommand.cs

@@ -2,10 +2,7 @@
 
 internal sealed class InfoCommand : Command<BenchmarkSettings>
 {
-    [SuppressMessage("ReSharper", "RedundantNullableFlowAttribute")]
-    public override int Execute(
-        [NotNull] CommandContext context,
-        [NotNull] BenchmarkSettings settings)
+    public override int Execute(CommandContext context, BenchmarkSettings settings)
     {
         ConsoleWriter.WriteHeader();
 

Benchmarks.App/Commands/ListCommand.cs

@@ -2,8 +2,7 @@
 
 internal sealed class ListCommand : Command
 {
-    [SuppressMessage("ReSharper", "RedundantNullableFlowAttribute")]
-    public override int Execute([NotNull] CommandContext context)
+    public override int Execute(CommandContext context)
     {
         ConsoleWriter.WriteHeader();
 

Benchmarks.App/Commands/WorkflowCommand.cs

@@ -2,8 +2,7 @@
 
 internal sealed class WorkflowCommand : Command
 {
-    [SuppressMessage("ReSharper", "RedundantNullableFlowAttribute")]
-    public override int Execute([NotNull] CommandContext context)
+    public override int Execute(CommandContext context)
     {
         if (BenchmarkRunner.IsDebugConfiguration(true))
         {

Benchmarks.App/Menus/BenchmarkMenu.cs

@@ -2,7 +2,7 @@
 
 internal sealed class BenchmarkMenu : MenuBase
 {
-    private Benchmark Benchmark { get; init; }
+    private Benchmark Benchmark { get; }
 
     public BenchmarkMenu(Benchmark benchmark)
     {

Benchmarks.App/Menus/MainMenu.cs

@@ -12,6 +12,7 @@ public MainMenu()
             new ExitSelection(4) { ExitApp = true }
         };
     }
+
     public override int Render()
     {
         var selected = Choices.First();

Benchmarks.App/Menus/Selections/ListSelection.cs

@@ -30,7 +30,11 @@ public override int Execute()
         // Would also be good to filter by keyboard input e.g. Esc to return to main menu
         prompt.AddChoice(new Benchmark("Exit"));
 
-        var table = new Table { Border = TableBorder.Simple };
+        var table = new Table
+        {
+            Border = TableBorder.Simple,
+            BorderStyle = new Style(foreground: Color.Grey)
+        };
         table.AddColumns("Benchmark", "Description", "Category");
         table.Columns[0].Width = padding.NamePad;
         table.Columns[1].Width = padding.DescriptionPad;

Benchmarks.App/Reflection.cs

@@ -34,7 +34,6 @@ private static Benchmark GetBenchmark(MemberInfo memberInfo)
             attribute.Category);
     }
 
-
     public static IEnumerable<Type> GetBenchmarkTypes() =>
         typeof(GuidPrimaryKey).Assembly
             .GetTypes()

Benchmarks.App/SpectreLogger.cs

@@ -4,20 +4,11 @@ internal sealed class SpectreLogger : ILogger
 {
     public static readonly SpectreLogger Logger = new();
 
-    public void Write(LogKind logKind, string text)
-    {
-        Markup(logKind, text, writeLine: false);
-    }
+    public void Write(LogKind logKind, string text) => Markup(logKind, text, writeLine: false);
 
-    public void WriteLine()
-    {
-        AnsiConsole.WriteLine();
-    }
+    public void WriteLine() => AnsiConsole.WriteLine();
 
-    public void WriteLine(LogKind logKind, string text)
-    {
-        Markup(logKind, text, writeLine: true);
-    }
+    public void WriteLine(LogKind logKind, string text) => Markup(logKind, text, writeLine: true);
 
     public void Flush()
     {

Benchmarks/GuidPrimaryKey.cs

@@ -54,7 +54,7 @@ public async Task Setup()
     [Benchmark]
     public async Task InsertGuidPrimaryKeyPostgres()
     {
-        using var dbContext = CreateDbContext(DbServer.Postgres);
+        await using var dbContext = CreateDbContext(DbServer.Postgres);
         await dbContext.Database.MigrateAsync();
         await dbContext.ClusteredIndexes.AddRangeAsync(CreateEntities<ClusteredIndex>());
         await dbContext.SaveChangesAsync();
@@ -63,7 +63,7 @@ public async Task InsertGuidPrimaryKeyPostgres()
     [Benchmark]
     public async Task InsertGuidPrimaryKeyWithClusteredIndexSqlServer()
     {
-        using var dbContext = CreateDbContext(DbServer.SqlServer);
+        await using var dbContext = CreateDbContext(DbServer.SqlServer);
         await dbContext.Database.MigrateAsync();
         await dbContext.ClusteredIndexes.AddRangeAsync(CreateEntities<ClusteredIndex>());
         await dbContext.SaveChangesAsync();
@@ -72,7 +72,7 @@ public async Task InsertGuidPrimaryKeyWithClusteredIndexSqlServer()
     [Benchmark]
     public async Task InsertGuidPrimaryKeyWithNonClusteredIndexSqlServer()
     {
-        using var dbContext = CreateDbContext(DbServer.SqlServer);
+        await using var dbContext = CreateDbContext(DbServer.SqlServer);
         await dbContext.Database.MigrateAsync();
         await dbContext.NonClusteredIndexes.AddRangeAsync(CreateEntities<NonClusteredIndex>());
         await dbContext.SaveChangesAsync();