Lps 72500 #11
Open
Lps 72500 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaned up properly when unregistered Change-Id: I45139c151a34a254e9347d1ac430026a60158018 Signed-off-by: Thomas Watson <[email protected]>
Change-Id: I125f389a742a26dd18a03da736bb0de34a5b4871 Signed-off-by: Thomas Watson <[email protected]>
Increment micro version by 100 for Mars.2
…y incompatible with Apache commons fileupload Signed-off-by: Raymond Auge <[email protected]>
…spatcher type is REQUEST Signed-off-by: Juan Gonzalez <[email protected]>
Change-Id: Icc74d86eb513fe9d01b0b26620980c7ab3a8b9bb Signed-off-by: Thomas Watson <[email protected]>
… squashed master impl) Signed-off-by: Raymond Auge <[email protected]>
Signed-off-by: Raymond Auge <[email protected]>
httpServiceRuntimeImpl is null
ServletContext init params
Signed-off-by: Raymond Auge <[email protected]>
…pl to HttpServletRequestWrapperImpl Signed-off-by: Raymond Auge <[email protected]>
…request attributes
…some cases Signed-off-by: Raymond Auge <[email protected]>
correctly for getAuthType or getRemoteUser Change-Id: I70c78a5bb4610a3fd4c4958e523b8a217a52bd00 Signed-off-by: Thomas Watson <[email protected]>
…n the whiteboard Signed-off-by: Raymond Auge <[email protected]>
Signed-off-by: Raymond Auge <[email protected]>
Signed-off-by: Carlos Sierra Andrés <[email protected]>
Signed-off-by: Raymond Auge <[email protected]>
…n the whiteboard Signed-off-by: Raymond Auge <[email protected]>
Using `new Boolean()` results in the creation of a new object on the heap, when the flyweight `Boolean.TRUE` and `Boolean.FALSE` are available. Java 1.4 added a `Boolean.valueOf()` which can be used in place of `new Boolean()` but which will use the existing flyweight values instead. Globally change `new Boolean(...)` to `Boolean.valueOf(...)` and replace constant valued expressions with their flyweight counterparts. Bug: 470518 Change-Id: I25742c65162e57fd553dd1284ec057cd4b333dbb Signed-off-by: Alex Blewitt <[email protected]>
….tests" This reverts commit d0528a4.
…value is null, in order to fulfill httpSession.setAttribute API Signed-off-by: Juan Gonzalez <[email protected]>
…methods too so everything cleans up Signed-off-by: Juan Gonzalez <[email protected]>
Signed-off-by: Matthew Tambara <[email protected]>
Signed-off-by: Matthew Tambara <[email protected]>
Signed-off-by: Matthew Tambara <[email protected]>
Signed-off-by: shuyangzhou <[email protected]>
…ibute, the synchronized protection should be per outter session based, no need to be system wide. Signed-off-by: shuyangzhou <[email protected]>
…ng is fine. HttpSession is thread safe to ensure attributes' memory visibility, no need to sync on read. Signed-off-by: shuyangzhou <[email protected]>
…()/removeReference(), when concurrent destroy() happens in between the addReference()/removeReference() window times, upgrade to write lock to ensure proper Condition waiting. Signed-off-by: shuyangzhou <[email protected]>
…eference()/removeReference(), when concurrent destroy() happens in between the addReference()/removeReference() window times, upgrade to write lock to ensure proper Condition waiting." This reverts commit 05be60b.
…he reading is fine. HttpSession is thread safe to ensure attributes' memory visibility, no need to sync on read." This reverts commit f2c5790.
…n's attribute, the synchronized protection should be per outter session based, no need to be system wide." This reverts commit aab7a09.
…king." This reverts commit 6abbd98.
This reverts commit d682850.
This reverts commit 7efed00.
This reverts commit b35078b.
…() is never used, let's defer the toString value calculation when it is really needed." This reverts commit ce3111a.
This reverts commit 6c8a301.
This reverts commit 9a21542.
This reverts commit eb6d8cb.
This reverts commit 94e335c.
This reverts commit f77fbdf.
This reverts commit dd25d52.
This reverts commit 12a1175.
This reverts commit edd5368.
This reverts commit e39933e.
This reverts commit d877b97.
This reverts commit c06bb01.
https://issues.liferay.com/browse/LPS-66801 https://issues.liferay.com/browse/LPS-66813 https://issues.liferay.com/browse/LPS-66827 https://issues.liferay.com/browse/LPS-66847 https://issues.liferay.com/browse/LPS-66881 https://issues.liferay.com/browse/LPS-66903 https://issues.liferay.com/browse/LPS-66904 https://issues.liferay.com/browse/LPS-66908 https://issues.liferay.com/browse/LPS-66911 https://issues.liferay.com/browse/LPS-66959 Signed-off-by: shuyangzhou <[email protected]> Signed-off-by: Matthew Tambara <[email protected]> Signed-off-by: Raymond Auge <[email protected]>
LPS-67139 Defer toString() value calculation LPS-69622 Dead field, never initialized, never used. LPS-69622 Use ConcurrentHashMap rather than synchronized all methods. LPS-69622 Use AtomicInteger to prevent lost counting. LPS-69622 Fallback to JDK6 only api. To ensure thread safety, createContextAttributes()/destroyContextAttributes() must still have the synchronized protection, consider they are only used during application initialization/destroy, there is no runtime overhead. At least this way getContextAttributes() is synchronized free, which is the most important thing to have. LPS-69622 Avoid using Hashtable, it just needs to be a Dictionary, delegate to ConcurrentHashMap LPS-69880 Avoid creating HttpSessionEvent unless there is any HttpSessionListener registered LPS-69882 Avoid duplicated path string indexing and splitting LPS-69883 The only creation of HttpServiceRuntimeImpl in Activator.addingService() is already wrapping the serviceProperties with UMDictionaryMap, inside HttpServiceRuntimeImpl constructor, there is no need to wrap it. LPS-69903 Shortcut as early as possible LPS-69903 Avoid using java.util.Stack, use LinkedList instead Signed-off-by: shuyangzhou <[email protected]> Signed-off-by: Matthew Tambara <[email protected]> Signed-off-by: Raymond Auge <[email protected]>
… them. Fix ListenerRegistration.equals so it gets actually removed from available EventListeners Signed-off-by: Juan Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.