Skip to content

feat(common): project compute type #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(common): project compute type #1990

wants to merge 4 commits into from

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Mar 1, 2025

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds compute type and proxy type configuration options to the project model in both TypeScript and Rust implementations.

  • Added ComputeType enum with Fargate and FargateSpot variants in both languages to specify deployment compute resources
  • Added ProxyType enum with ShuttleProxy and AwsAlb variants to define how traffic is routed to deployments
  • Updated ProjectResponse and ProjectUpdateRequest structures to include these new optional configuration fields
  • Enhanced the to_string_colored method in Rust to display the new compute and proxy type information

Greptile AI

2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR removes the proxy_type field and ProxyType enum while retaining the compute_type field in the project model.

  • Removed proxy_type field from ProjectResponse and ProjectUpdateRequest structs in Rust
  • Removed ProxyType enum and its references from TypeScript interfaces
  • Simplified project configuration by eliminating proxy type as a configurable option
  • Retained ComputeType enum with Fargate and FargateSpot variants for deployment resource specification

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 changed the title feat(common): project compute type, proxy type feat(common): project compute type Mar 5, 2025
@jonaro00 jonaro00 marked this pull request as draft March 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant