Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #1763 #1812

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix for Issue #1763 #1812

wants to merge 4 commits into from
+242 −261

Conversation

joshuabvarghese
Copy link

Refactor PendingRequestState and KafkaSinkCluster

This PR refactors the PendingRequestState enum and related components in the KafkaSinkCluster implementation.

  • Removed redundant destination field from all PendingRequestState variants.
  • Added destination field to the PendingRequest struct.
  • Updated PendingRequestState::routed method to exclude destination.
  • Modified methods in KafkaSinkCluster to utilize the new structure.
  • Ensured all relevant code is updated to maintain functionality.

Testing

  • All existing tests updated and passing.
  • Integration tests executed successfully.

This refactoring improves code organization and reduces redundancy.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rukai rukai marked this pull request as ready for review November 14, 2024 06:42
@rukai rukai marked this pull request as draft November 14, 2024 06:42
@rukai
Copy link
Member

rukai commented Nov 14, 2024

Hi Joshua, thanks for the PR!
Looks like you have some compiler errors that need to be resolved, let me know if you need any pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuabvarghese @CLAassistant @rukai