chore(deps-dev): Bump phpstan/phpstan from 1.12.0 to 1.12.5 #2766
Conversation
and fix some phpstan errors
|
| @@ -46,15 +44,21 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $conn = $this->container->get(\Doctrine\DBAL\Connection::class); | |||
| $elementId = $conn->fetchColumn('SELECT id FROM s_core_config_elements WHERE name LIKE "firstRunWizardEnabled"'); | |||
| $elementId = is_numeric($elementId) ? (int) $elementId : 0; | |||
There was a problem hiding this comment.
wouldn't false be cast to 0 anyway?
There was a problem hiding this comment.
The problem is, that this version of doctrine returns mixed|false, therefore this check. But it probably should be replaced by fetchOne (which returns mixed|false as well).
| $valueid = $conn->fetchColumn('SELECT id FROM s_core_config_values WHERE element_id = :elementId', ['elementId' => $elementId]); | ||
| $valueid = is_numeric($valueid) ? (int) $valueid : 0; |
| * {@inheritdoc} | ||
| */ | ||
| protected function configure() | ||
| protected function configure(): void |
There was a problem hiding this comment.
I guess this would be a breaking change, strictly speaking 😬
There was a problem hiding this comment.
Mh, does someone extend commands? But probably as they are not internal, it might be a BC.
| * {@inheritdoc} | ||
| */ | ||
| protected function configure() | ||
| protected function configure(): void |
| @@ -46,15 +44,21 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $conn = $this->container->get(\Doctrine\DBAL\Connection::class); | |||
| $elementId = $conn->fetchColumn('SELECT id FROM s_core_config_elements WHERE name LIKE "firstRunWizardEnabled"'); | |||
| $elementId = is_numeric($elementId) ? (int) $elementId : 0; | |||
There was a problem hiding this comment.
same as above
I see an abstraction potential here 😁
There was a problem hiding this comment.
Yes, I was thinking about this as well, but then we would have inherited commands and I was not sure where to place them, and then I thought, okay maybe for phpstan cleanup, it is enough to adjust it twice :D
| @@ -97,9 +102,9 @@ private function addCronjob(Plugin $plugin, $cronjob) | |||
| } | |||
|
|
|||
| /** | |||
| * @param int $pluginId | |||
| * @param array<string> $cronjobActions | |||
There was a problem hiding this comment.
| * @param array<string> $cronjobActions | |
| * @param list<string> $cronjobActions |
| @@ -41,7 +41,11 @@ public function __construct(Connection $connection) | |||
| } | |||
|
|
|||
| /** | |||
| * @param array<array<string, mixed>> $cronjobs | |||
There was a problem hiding this comment.
really fancy would be an object shape annotation of the array 😇
There was a problem hiding this comment.
Yeah, I will look into it, I still need to adjust the code, that the pipeline for php 7.4 still works :-)
| static::assertInstanceOf(Unit::class, $price->getUnit()); | ||
| static::assertGreaterThanOrEqual(1, $price->getUnit()->getMinPurchase()); | ||
| } | ||
|
|
||
| foreach ($product->getPriceRules() as $price) { |
There was a problem hiding this comment.
can we check the rules in another way? that they are correctly present?
and fix some phpstan errors