chore(docs): add best practices to README #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pweyck
force-pushed
the
add-best-practices
branch
from
3259caa
to
2c8068a
Compare
frobel
reviewed
Jul 19, 2024
| - categories | ||
| - do not expect the shop to have the defaults en_GB and EUR | ||
| - do not change global settings (sales channel is ok, because it's created by us) |
There was a problem hiding this comment.
What do you mean by global settings? Providing some examples would make it much more transparent.
frobel
previously approved these changes
Jul 19, 2024
pweyck
force-pushed
the
add-best-practices
branch
from
2c8068a
to
923f746
Compare
frobel
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rendered:
https://github.com/shopware/acceptance-test-suite/blob/add-best-practices/README.md#best-practices