Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set type: module #124

Merged
merged 1 commit into from
Oct 15, 2024
Merged

set type: module #124

merged 1 commit into from
Oct 15, 2024

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Sep 13, 2024

Without this change I got

// BaseTestFile.ts
import { test as base } from '@shopware-ag/acceptance-test-suite';
                                                                  
SyntaxError: Cannot use import statement outside a module

I am not sure if that is the proper solution, so it's open for discussion

Without this change I got

```
// BaseTestFile.ts
import { test as base } from '@shopware-ag/acceptance-test-suite';
                                                                  
SyntaxError: Cannot use import statement outside a module
```

I am not sure if that is the proper solution, so it's open for discussion
@shyim
Copy link
Member

shyim commented Sep 13, 2024

We could use here https://github.com/isaacs/tshy , so the result package is common js and module js 🤔

@amenk
Copy link
Contributor Author

amenk commented Sep 13, 2024

Not sure if I understand.

I had to add this to the package.json of my project which uses the test-suite plugin and was created as described in the README

The BaseTestFile.ts is located in my project.
I dont build any dist of my test-project.

@frobel frobel merged commit a46a037 into shopware:trunk Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants