Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 pattern import export impr imports #120

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

hparfr
Copy link
Contributor

@hparfr hparfr commented Apr 3, 2023

This PR allows you to do 2 new interesting things:

  1. define a primary key with multiple columns and multiple depth
  2. define foreign key with multiple columns and multiple depth

TODO:

  • tests
  • update documentation
  • minor refactor and add comments

@hparfr hparfr requested a review from sebastienbeau April 3, 2023 15:42
@hparfr hparfr force-pushed the 14.0-pattern_import_export-impr-imports branch from ccbb449 to 8f38e48 Compare April 14, 2023 11:44
@hparfr
Copy link
Contributor Author

hparfr commented Dec 21, 2023

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-120-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Dec 21, 2023
Signed-off-by hparfr
@shopinvader-git-bot
Copy link

@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-120-by-hparfr-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hparfr hparfr force-pushed the 14.0-pattern_import_export-impr-imports branch from c382da6 to 690d680 Compare December 21, 2023 08:22
@hparfr
Copy link
Contributor Author

hparfr commented Dec 21, 2023

/ocabot merge minor

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-120-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Dec 21, 2023
Signed-off-by hparfr
@shopinvader-git-bot
Copy link

@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-120-by-hparfr-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hparfr hparfr force-pushed the 14.0-pattern_import_export-impr-imports branch from 690d680 to cc13385 Compare December 21, 2023 09:08
allow to define multiple columns as primary key
with depth > 1
convert_value_to_domain,
pk with multiple values,
fk with multiple values
@hparfr hparfr force-pushed the 14.0-pattern_import_export-impr-imports branch from cc13385 to 5bcf998 Compare December 21, 2023 11:13
@hparfr
Copy link
Contributor Author

hparfr commented Dec 21, 2023

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-120-by-hparfr-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit f35401b into 14.0 Dec 21, 2023
4 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 63ac142. Thanks a lot for contributing to shopinvader. ❤️

@shopinvader-git-bot shopinvader-git-bot deleted the 14.0-pattern_import_export-impr-imports branch December 21, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants