[FIX] avoid crash when changing a relational field to simple field #108
Conversation
|
code and functionnal review LGTM |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-108-by-hparfr-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
florian-dacosta
force-pushed
the
14-fix-crash-change-field1
branch
from
3e342e2 to
20ad292
Compare
|
@hparfr I did rebase, maybe you could try again to merge it |
Example of crash before this fix : on res.partner, choose country_id as field1_id and code as field2_id then change field1_id for active name field is not updated yet at the time it goes through _get_last_relation_field so odoo expected a relational field even though it is not anymore it is not anymore
florian-dacosta
force-pushed
the
14-fix-crash-change-field1
branch
from
20ad292 to
7a697c0
Compare
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2d19948. Thanks a lot for contributing to shopinvader. ❤️ |
Example of crash before this fix : on res.partner, choose country_id as field1_id and code as field2_id then change field1_id for active
name field is not updated yet at the time it goes through _get_last_relation_field so odoo expected a relational field even though it is not anymore and crashes.