Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] invader_payment_adyen_sepa - Multi company #93

Conversation

acsonefho
Copy link

@acsonefho acsonefho commented Nov 1, 2023

Add multi-company feature for Adyen SEPA

  • Currently the acquirer set on the payment method is the same for every companies. Change this field to be company dependent. (because we can not duplicate the payment method as the code is unique)
  • Add related unit test for this multi-company use-case

@acsonefho acsonefho changed the title [IMP] invader_payment_adyen_sepa - Multi company [14.0][IMP] invader_payment_adyen_sepa - Multi company Nov 3, 2023
- Currently the acquirer set on the payment method is the same for every companies. Change this field to be company dependent. (because we can not duplicate the payment method as the code is unique)
- Add related unit test for this multi-company use-case
@acsonefho acsonefho force-pushed the 14.0-invader_payment_adyen_sepa_multi_company branch from 739507e to 5c8d781 Compare December 7, 2023 09:58
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3d5a847) 76.18% compared to head (5c8d781) 76.98%.
Report is 4 commits behind head on 14.0.

Files Patch % Lines
...payment_adyen_sepa/models/account_payment_order.py 85.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0      #93      +/-   ##
==========================================
+ Coverage   76.18%   76.98%   +0.79%     
==========================================
  Files         115      115              
  Lines        1793     1868      +75     
  Branches      217      222       +5     
==========================================
+ Hits         1366     1438      +72     
- Misses        369      370       +1     
- Partials       58       60       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acsonefho
Copy link
Author

@shopinvader/shopinvader-maintainers Can you review/merge this one please? 🙏
In production since mid-november.

Copy link

@xavier-bouquiaux xavier-bouquiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Already in production

Copy link

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-93-by-hparfr-bump-minor, awaiting test results.

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@shopinvader-git-bot shopinvader-git-bot merged commit e214c8e into shopinvader:14.0 Dec 7, 2023
4 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at ad8ee05. Thanks a lot for contributing to shopinvader. ❤️

@acsonefho acsonefho deleted the 14.0-invader_payment_adyen_sepa_multi_company branch December 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants