-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] invader_payment_adyen_sepa - Multi company #93
[14.0][IMP] invader_payment_adyen_sepa - Multi company #93
Conversation
- Currently the acquirer set on the payment method is the same for every companies. Change this field to be company dependent. (because we can not duplicate the payment method as the code is unique) - Add related unit test for this multi-company use-case
739507e
to
5c8d781
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #93 +/- ##
==========================================
+ Coverage 76.18% 76.98% +0.79%
==========================================
Files 115 115
Lines 1793 1868 +75
Branches 217 222 +5
==========================================
+ Hits 1366 1438 +72
- Misses 369 370 +1
- Partials 58 60 +2 ☔ View full report in Codecov by Sentry. |
@shopinvader/shopinvader-maintainers Can you review/merge this one please? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Already in production
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
On my way to merge this fine PR! |
This PR has the |
Congratulations, your PR was merged at ad8ee05. Thanks a lot for contributing to shopinvader. ❤️ |
Add multi-company feature for Adyen SEPA