[16.0] [mig] shopinvader_delivery_pickup_colissimo_widget #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "external_dependencies": {"python": [], "bin": []}, | ||
| "depends": [ | ||
| "shopinvader_api_delivery_pickup_public_edition", | ||
| "delivery_roulier_laposte_fr", |
There was a problem hiding this comment.
After thinking twice, depending on "delivery_roulier_laposte_fr" is maybe overkill.
We only need this for having the user/password of la poste.
What we can do is the following.
In this module just store the user / password in the ir.config.parameter
laposte.user
laposte.password
Then we can do a glue module with "delivery_roulier_laposte_fr" (this can be done later in an other PR)
That use the user/password stored in the "delivery_carrier_account" https://github.com/OCA/delivery-carrier/blob/16.0/delivery_carrier_account
So in case that you do not print label you do not need to install "delivery_roulier_laposte_fr"
chafique-delli
force-pushed
the
16.0-mig-shopinvader_delivery_pickup_colissimo_widget
branch
from
cf822fa
to
bcf7760
Compare
chafique-delli
force-pushed
the
16.0-mig-shopinvader_delivery_pickup_colissimo_widget
branch
from
bcf7760
to
a2d06f2
Compare
chafique-delli
force-pushed
the
16.0-mig-shopinvader_delivery_pickup_colissimo_widget
branch
4 times, most recently
from
b8b65f9
to
7cacd65
Compare
chafique-delli
force-pushed
the
16.0-mig-shopinvader_delivery_pickup_colissimo_widget
branch
from
7cacd65
to
e6126bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.