Fixes

shnikd · May 24, 2024 · 3681cf5 · 3681cf5
1 parent 3483a51
commit 3681cf5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/ydb/library/yql/sql/pg/pg_sql.cpp b/ydb/library/yql/sql/pg/pg_sql.cpp
@@ -2968,8 +2968,7 @@ class TConverter : public IPGParseEvents {
         return State.Statements.back();
     }
 
-    [[nodiscard]] 
-    TFromDesc ParseFromClause(const Node* node) {
+    TMaybe<TFromDesc> ParseFromClause(const Node* node) {
         switch (NodeTag(node)) {
         case T_RangeVar:
             return ParseRangeVar(CAST_NODE(RangeVar, node));

diff --git a/ydb/library/yql/sql/pg/pg_sql_ut.cpp b/ydb/library/yql/sql/pg/pg_sql_ut.cpp
@@ -311,17 +311,17 @@ Y_UNIT_TEST_SUITE(PgSqlParsingOnly) {
         const auto expectedAst = NYql::ParseAst(program);
         UNIT_ASSERT_STRINGS_EQUAL(res.Root->ToString(), expectedAst.Root->ToString());
     }
+
     Y_UNIT_TEST(AlterTableStmt) {
         auto res = PgSqlToYql("ALTER TABLE public.t ALTER COLUMN id SET DEFAULT nextval('seq');");
         UNIT_ASSERT_C(res.Root, res.Issues.ToString());
         TString program = R"(
             (
                 (let world (Configure! world (DataSource 'config) 'OrderedColumns)) 
                 (let world (Write! world (DataSink '"kikimr" '"") 
-                    (Key '('tablescheme (String '"t"))) 
-                    (Void) '('('mode 'alter) '('actions '('alterColumns '('('"id" '('setDefault '('nextval 'seq))))))))) 
+                    (Key '('tablescheme (String '"t"))) (Void) '('('mode 'alter) '('actions '('('alterColumns '('('"id" '('setDefault '('nextval 'seq)))))))))) 
                 (let world (CommitAll! world)) (return world)
-            )  
+            )
         )";
         const auto expectedAst = NYql::ParseAst(program);
         UNIT_ASSERT_STRINGS_EQUAL(res.Root->ToString(), expectedAst.Root->ToString());