Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dependency on uuid package back to fix error on non-secure contexts #1327

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 9, 2024

Closes #1325

Use uuid package to generate UUIDs, instead of crypto.randomUUID(), as the latter is only available when the app runs in secure context.

Copy link

github-actions bot commented Oct 9, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.13%. Comparing base (b0aff16) to head (453d245).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/utils/utils.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1327   +/-   ##
========================================
  Coverage    79.13%   79.13%           
========================================
  Files           49       49           
  Lines         1270     1275    +5     
  Branches       243      244    +1     
========================================
+ Hits          1005     1009    +4     
  Misses          23       23           
- Partials       242      243    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit e8c5ac8 into shlinkio:develop Oct 9, 2024
7 checks passed
@acelaya acelaya deleted the feature/uuid-fix branch October 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto.randomUUID not found
1 participant