-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add relationship between core entities to make it persistable in database #195
Open
shivasurya
wants to merge
29
commits into
main
Choose a base branch
from
shiva/graph-relation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,842
−3,168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
===========================================
- Coverage 72.42% 13.78% -58.64%
===========================================
Files 16 30 +14
Lines 2473 2966 +493
===========================================
- Hits 1791 409 -1382
- Misses 639 2545 +1906
+ Partials 43 12 -31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds relationship between the entities which should help to store them in relational format. Creating relationship between the entities reduces drastically search space to filter nodes while
codeql
query is executed. Further more adopting #190 class support further drives to implement class and filters by the end users to reduce the search space.cartesian product
and waste memory and computing time. We could warn the user by checking the cardinality of the dataset before filtering or generating cartesian product and let the user decide to run the query.Checklist:
gradle testGo
)?golangci-lint run
this requires golangci-lint)?