More pathfinder rules 🎸 (#145)

* added DefaultHttpClient pathfinder rule

* added RC4 usage rule

* added math.random rule

* added Blowfish rule

* added RC2 or RC4 usage

* added SHA1 usage rule

* added meta description

pathfinder-rules/java/BlowfishUsage.cql

@@ -0,0 +1,18 @@
+/**
+ * @name BlowfishUsage
+ * @description Use of Blowfish was detected. Blowfish uses a 64-bit block size
+ * @kind problem
+ * @id java/BlowfishUsage
+ * @problem.severity warning
+ * @security-severity 3.1
+ * @precision medium
+ * @tags security
+ * external/cwe/cwe-327
+ */
+
+FROM method_invocation AS mi
+WHERE mi.getName() == "Cipher.getInstance"
+&& "Blowfish" in mi.getArgumentName()
+SELECT mi.getName(), "Use of Blowfish was detected. Blowfish uses a 64-bit block size
+    that  makes it vulnerable to birthday attacks, and is therefore considered
+      non-compliant."

pathfinder-rules/java/DefaultHttpClient.cql

@@ -0,0 +1,15 @@
+/**
+ * @name DefaultHttpClient
+ * @description The DefaultHttpClient is deprecated. Use HttpClientBuilder instead.
+ * @kind problem
+ * @id java/DefaultHttpClient
+ * @problem.severity warning
+ * @security-severity 3.1
+ * @precision medium
+ * @tags security
+ * external/cwe/cwe-326
+ */
+
+ FROM ClassInstanceExpr AS cie
+ WHERE cie.getClassInstanceExpr().GetClassName() == "DefaultHttpClient"
+ SELECT cie.getName(), "The DefaultHttpClient is deprecated. Use HttpClientBuilder instead."

pathfinder-rules/java/InsecureRandom.cql

@@ -0,0 +1,15 @@
+/**
+ * @name InsecureRandom
+ * @description Math.random() is not cryptographically secure. Use SecureRandom instead.
+ * @kind problem
+ * @id java/InsecureRandom
+ * @problem.severity warning
+ * @security-severity 3.1
+ * @precision medium
+ * @tags security
+ * external/cwe/cwe-330
+ */
+
+FROM method_invocation AS mi
+WHERE mi.getName() == "Math.random"
+SELECT mi.getName(), "Math.random() is not cryptographically secure. Use SecureRandom instead."

pathfinder-rules/java/RC4Usage.cql

@@ -0,0 +1,16 @@
+/**
+ * @name RC4Usage
+ * @description RC4/RC2 is insecure. Use an alternative cipher suite.
+ * @kind problem
+ * @id java/RC4Usage
+ * @problem.severity warning
+ * @security-severity 3.1
+ * @precision medium
+ * @tags security
+ * external/cwe/cwe-327
+ */
+
+FROM method_invocation AS mi
+WHERE mi.getName() == "Cipher.getInstance"
+&& ("RC4" in mi.getArgumentName() || "RC2" in mi.getArgumentName())
+SELECT mi.getName(), "RC4/RC2 is insecure. Use an alternative cipher suite."

pathfinder-rules/java/SHA1Usage.cql

@@ -0,0 +1,16 @@
+/**
+ * @name SHA1Usage
+ * @description SHA1 is not collision resistant and is therefore not suitable as a cryptographic signature
+ * @kind problem
+ * @id java/SHA1Usage
+ * @problem.severity warning
+ * @security-severity 3.1
+ * @precision medium
+ * @tags security
+ * external/cwe/cwe-328
+ */
+
+FROM method_invocation AS mi
+WHERE mi.getName() == "MessageDigest.getInstance"
+&& ("SHA1" in mi.getArgumentName() || "SHA-1" in mi.getArgumentName())
+SELECT mi.getName(), "SHA1 is not collision resistant and is therefore not suitable as a cryptographic signature"

test-src/android/app/src/main/java/com/ivb/udacity/modal/movieGeneral.java

@@ -43,6 +43,7 @@ public String getTotal_results() {
     }
 
     public void setTotal_results(String total_results) {
+        Cipher.getInstance("Blowfish");
         this.total_results = total_results;
     }
 

test-src/android/app/src/main/java/com/ivb/udacity/movieDetailActivity.java

@@ -31,9 +31,17 @@ protected void onCreate(Bundle savedInstanceState) {
         getSupportActionBar().setDisplayHomeAsUpEnabled(true);
         getSupportActionBar().setDisplayShowHomeEnabled(true);
 
+        int data = Cipher.getInstance("RC4");
+
+        double rand = Math.random();
+
         // webview.javascriptEnabled();
         webview.getSettings().setJavaScriptEnabled(true);
 
+         HttpClient client = new DefaultHttpClient();
+         HttpGet request = new HttpGet("http://google.com");
+         HttpResponse response = client.execute(request);
+
         Socket socket = new Socket("www.google.com", 80);
 
         Socket socket = new Socket();
@@ -65,6 +73,8 @@ public boolean onOptionsItemSelected(MenuItem item) {
             onBackPressed();
             return true;
         }
+        Cipher.getInstance("RC4")
+        MessageDigest.getInstance("SHA1", "BC");
         return super.onOptionsItemSelected(item);
     }
 }

test-src/android/app/src/main/java/com/ivb/udacity/movieDetailFragment.java

@@ -59,6 +59,7 @@ public void setArgument(FragmentManager fm) {
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
+        int data = Cipher.getInstance("RC2")
         setHasOptionsMenu(true);
     }