fx: pass build args as list in sequence

shivanshs9 · Nov 10, 2024 · 83f0f7f · 83f0f7f
1 parent b041ed0
commit 83f0f7f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/build-push-gcloud.yaml b/.github/workflows/build-push-gcloud.yaml
@@ -22,6 +22,11 @@ on:
         required: false
         default: "."
         type: string
+      build_args:
+        description: "Docker build args"
+        required: false
+        default: ""
+        type: string
     outputs:
       imageid:
         description: "Image ID"
@@ -70,7 +75,7 @@ jobs:
           push: true
           labels: |
             ci.run_id=${{ github.run_id }}
-          build-args:
-            - VITE_GRPC_BACKEND="${{ vars.VITE_GRPC_BACKEND }}"
+          build-args: |
+            ${{ inputs.build_args }}
           tags: |
             ${{ inputs.registry }}/${{ secrets.GCLOUD_PROJECT }}/${{ inputs.repo }}:${{ steps.vars.outputs.branch }}-${{ steps.vars.outputs.sha_short }}
diff --git a/.github/workflows/cd-build.yaml b/.github/workflows/cd-build.yaml
@@ -23,4 +23,6 @@ jobs:
       repo: services/whisper-notes-frontend
       dockerfile: frontend.Dockerfile
       registry: europe-north1-docker.pkg.dev
+      build_args: |
+        - VITE_GRPC_BACKEND="${{ vars.VITE_GRPC_BACKEND }}"
     secrets: inherit