Skip to content
This repository was archived by the owner on Jul 17, 2023. It is now read-only.

M3 switch language #33

Merged
merged 7 commits into from
Oct 22, 2021
Merged

M3 switch language #33

merged 7 commits into from
Oct 22, 2021

Conversation

shirosweets
Copy link
Owner

@shirosweets shirosweets added the feature New implementation or requirement label Oct 22, 2021
@shirosweets shirosweets self-assigned this Oct 22, 2021
@shirosweets
Copy link
Owner Author

Es necesario esperar a que M3 refactor good practices #24 sea mergeado para actualizar la branch con main

Copy link
Collaborator

@RicardoLopez9908 RicardoLopez9908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProfileFragment:

diff

Tener en cuenta esto a la hora de hacer el merge.
El definitivo es "getString(R.string.my_address)" para evitar bugs.

app/build.gradle Outdated
Comment on lines 17 to 20
dataBinding{
enabled = true
}

Copy link
Collaborator

@AgustinMDominguez AgustinMDominguez Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No estamos usando Data Binding. Lo probe sin data binding y no se rompe nada, es seguro borrar estas lineas

@shirosweets
Copy link
Owner Author

@AgustinMDominguez

@shirosweets shirosweets merged commit a989797 into main Oct 22, 2021
@shirosweets shirosweets deleted the m3_switch_language branch October 22, 2021 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New implementation or requirement
Projects
None yet
3 participants