-
Notifications
You must be signed in to change notification settings - Fork 29
Ship 0039/261 - add --scheduler-name flag #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/status in-review |
This comment was marked as resolved.
This comment was marked as resolved.
@rxinui: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@adambkaplan Now that #260 is merged, this is now rebased on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Only notable issues seem related to rebasing. Otherwise the code looks good!
vendor/github.com/shipwright-io/build/pkg/apis/build/v1alpha1/build_types.go
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- test: add go test and bats tests Signed-off-by: rxinui <[email protected]>
@adambkaplan all good now. On a side note, I'll move back to neovim (or zed). |
e2e tests are not ending. None of them are related to my PRs - mine are OK. That is weird. Have you encountered that before? |
Changes
Fixes #261
Add CLI flag
--scheduler-name
to set.spec.schedulerName
to aBuild
orBuildRun
❗ IMPORTANT: depends on my other PR 309 as
v1beta1
is required (and inherently to PR 304)Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes