Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes indies, inteq and SRM use combustion thrusters instead of plasmas. #4080

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented Jan 25, 2025

About The Pull Request

Alongside replacing the thrusters I also:

  • Kilo, Mudskipper, Talos, Elder - replaced plasma canisters with fuel canisters.
  • Riggs, Colossus - replaced plasma pressure tanks with fuel canisters (as for Riggs- I couldn't really find the room to add fuel mixers, though it should get them I think - will think a bit more about it)
  • Shetland - I went a little overboard and made the TEG run on a hydrogen/oxygen mix, from which the thrusters feed. Should work about the same though. I hope so anyways.

Why It's Good For The Game

I've been told by @Apogee-dev that plasmas should be only used on NT ships. This fixes that.

Changelog

🆑
tweak: Kilo, Mudskipper, Riggs, Shetland, Colossus, Talos and Elder now use combustion thrusters instead of plasma thrusters.
tweak: Shetland's TEG now runs on hydrogen instead of plasma.
/:cl:

@Sadhorizon Sadhorizon requested review from a team as code owners January 25, 2025 22:50
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Ship Ship successfully tested. Code change Watch something violently break. labels Jan 25, 2025
@MemeSnorfer
Copy link
Contributor

MemeSnorfer commented Jan 25, 2025

Random thing about the Talos, actually. It does actually have plasma canisters in the maintenance wings, one on each wing, for each thruster (so it turns out one of the canisters were disappeared in the maints remap for the Talos). It's a small thing, but I imagine the thrusters were the whole reasoning for their existence in maints.

@Sadhorizon
Copy link
Contributor Author

Random thing about the Talos, actually. It does actually have plasma canisters in the maintenance wings, one on each wing, for each thruster (so it turns out one of the canisters were disappeared in the maints remap for the Talos). It's a small thing, but I imagine the thrusters were the whole reasoning for their existence in maints.

Accidently removed one in a previous PR- I'll just... give it two fuel ones again.

@Imaginos16 Imaginos16 added Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free. labels Jan 26, 2025
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jan 28, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 29, 2025
@Sadhorizon
Copy link
Contributor Author

Sadhorizon commented Jan 30, 2025

Oh and uh- please make sure the Shetland was tested before it's merged, I'm not an expert with atmos and I totally could have done it incorrectly/missed something important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. Sprites A bikeshed full of soulless bikes. Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants