Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Shiptest IRS Audit (Branch Edition) #3917

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

Geoengi
Copy link
Contributor

@Geoengi Geoengi commented Dec 17, 2024

About The Pull Request

  • Removes the ability to place material coins into slot machines by changing the pay mode; they only work with cash bundles now. Thank @flopppi for this wonderful edit.
  • Slot machines don't announce if you've won a jackpot to the whole sector.
  • The roulette table no longer gets stuck with spinning/persistent numbers and now references cash cards over ID cards. Also requires the machine to have power for it to spin and have the owner's card present to use the bolt button.
  • Roulette tables can be bought at cargo for 5000 credits.
  • Fixes some grammar relating to the roulette table's beacon and gives it an activation sound relating to it's activation message.
  • Vendors no longer ask for ID cards when no account is presented and instead cash cards.

Why It's Good For The Game

  • So turns out that if you place coins in a slot machine and go to withdraw them or deconstruct the machine, it literally tries to throw infinite coins at your head and kills the server. Obviously, it should not do this.
  • The roulette table is a fun item that should get more, gimmick or not, use than the one ship that had it (RIP Lagoon).
  • Consistency in terminology and missing feature fixes are also good in economy items, yes-yes.

Changelog

🆑
add: Roulette tables can be bought at cargo for the low price of 5000 credits!
fix: Fixed persistent overlays on roulette tables and requires them to be powered to function.
fix: Roulette tables now pay out when betting zero.
tweak: Owners of roulette tables are the only ones who can bolt or unbolt them.
tweak: Slot machines don't announce who won a jackpot where.
tweak: Replaced references to ID cards with cash cards where applicable.
tweak: The roulette beacon now has an activation sound.
spellcheck: The roulette beacon's description reads better.
code: Slot machines no longer accept material coins due to them nuking the server if withdrawn.
/:cl:

@github-actions github-actions bot added TGUI Code change Watch something violently break. labels Dec 17, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Geoengi
Copy link
Contributor Author

Geoengi commented Dec 30, 2024

guh???

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 31, 2024
code/game/machinery/roulette_machine.dm Outdated Show resolved Hide resolved
code/game/machinery/roulette_machine.dm Outdated Show resolved Hide resolved
code/game/machinery/slotmachine.dm Show resolved Hide resolved
code/modules/cargo/packs/civilian.dm Outdated Show resolved Hide resolved
code/game/machinery/slotmachine.dm Outdated Show resolved Hide resolved
@Geoengi Geoengi requested a review from FalloutFalcon January 6, 2025 23:29
@Geoengi
Copy link
Contributor Author

Geoengi commented Jan 9, 2025

Unsure why OpenDream is failing to install over a two-line change.

@FalloutFalcon
Copy link
Member

this is not your fault. one of my prs is blowing up as well... ill work on it.

@Geoengi
Copy link
Contributor Author

Geoengi commented Jan 10, 2025

Everything is mechanically fixed in this forsaken wheel, minus the TGUI bet table being squished (though I don't know where to start with that.) Unsure how MORE tests are failing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants