Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Tempchanges Revert #3895

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Dec 8, 2024

About The Pull Request

Partial revert of the temp changes introduced in #3512.

Temperature is an unfortunately horrific system that needs more work than value fudging to produce a good effect, and I am of the opinion that dealing with all the edge cases introduced by #3512 outweights the benefits it's produced

Changelog

🆑
balance: Temperature Mechanics have been partially reverted. Please report any weirdness
balance: Temperature now defaults to respecting insulation instead of ignoring it.
/:cl:

@keywordlabeler keywordlabeler bot added the Do Not Merge You probably made someone angry, or you're stopping people from getting angry. label Dec 8, 2024
@github-actions github-actions bot added the Code change Watch something violently break. label Dec 8, 2024
@Erikafox
Copy link
Contributor Author

Erikafox commented Dec 8, 2024

needs a testmerge to make sure that I have not caused any issues.

@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label Jan 3, 2025
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really cant parse much from the numbers without seeing it ingame myself, I havent played a ton recently to feel the temp effects. But i agree with the change for use_insulation default being true. Test merge required

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 7, 2025
@github-actions github-actions bot requested a review from FalloutFalcon January 7, 2025 17:59
@FalloutFalcon FalloutFalcon removed the Do Not Merge You probably made someone angry, or you're stopping people from getting angry. label Jan 17, 2025
@FalloutFalcon FalloutFalcon changed the title [DNM] Partial Tempchanges Revert Partial Tempchanges Revert Jan 17, 2025
@FalloutFalcon FalloutFalcon added this pull request to the merge queue Jan 17, 2025
Merged via the queue into shiptest-ss13:master with commit 03cfc29 Jan 17, 2025
16 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jan 19, 2025
## About The Pull Request
Partial revert of the temp changes introduced in shiptest-ss13#3512. 

Temperature is an unfortunately horrific system that needs more work
than value fudging to produce a good effect, and I am of the opinion
that dealing with all the edge cases introduced by shiptest-ss13#3512 outweights the
benefits it's produced

## Changelog

:cl:
balance: Temperature Mechanics have been partially reverted. Please
report any weirdness
balance: Temperature now defaults to respecting insulation instead of
ignoring it.
/:cl:

---------

Co-authored-by: FalloutFalcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants