Supercharged Flavourtext + Subtle Emote Refactor (again) #3877
+309
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DME Edit
TGUI
Code change
|
:emotion42: |
|
soon......:tm: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Moves flavourtext to TGUI, adding the ability to use markdown formatting and a character image (ONLY from imgur at the moment). Also refactors subtle emote to just be a version of normal emoting instead of weird separate somewhat-duplicate code.
TODO: Currently has two different versions, basically a better version of the old system, and the new TGUI system that uses a component. The first is accessed like normal, while the new system is accessed by examine-more-ing a human.
I can't actually test this because neither images nor the markdown parser works on wine lmao
Why It's Good For The Game
I always thought flavourtext and subtle emotes were rather neglected. This improves them a little bit at least.
Changelog
🆑
add: TGUI flavourtext and character images, which can be viewed by double-examining someone.
/:cl: