Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites Trickwine Fluff #3668

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

I tried my hand at rewriting the trickwine fluff to feel more... Lore. This included removing the overtly magical trickwines, rewriting the big fluff thing, and otherwise adjusting.

Why It's Good For The Game

Remains to be seen. Please leave your thoughts below. I will disregard them.

Changelog

🆑
add: Trickwine fluff has been rewritten
balance: Trickwines have been somewhat nerfed
del: prismwine, forcewine
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Oct 29, 2024
@Erikafox Erikafox requested a review from a team as a code owner October 29, 2024 04:55
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. labels Oct 29, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more thoughts, a further review later
Whats your reasoning for removing prism

boozepwr = 70
taste_description = "the adrenaline of the chase"
glass_name = "Shockwine"
boozepwr = 50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booze power is a balancing element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware.

@Erikafox
Copy link
Contributor Author

I have more thoughts, a further review later Whats your reasoning for removing prism

I put some thoughts into it and couldn't come to a base that I was satisfied with

Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you will want to get a review from valorium on the book but I wouldn't call them alchemists as I would prefer using brewing related terminology to lean away from them just being ghetto chemists.

@@ -633,22 +633,10 @@

/datum/chemical_reaction/hearth_wine
results = list(/datum/reagent/consumable/ethanol/trickwine/hearth_wine = 5)
required_reagents = list(/datum/reagent/consumable/ethanol/hcider = 3, /datum/reagent/consumable/pyre_elementum = 1, /datum/reagent/fuel = 1)
required_reagents = list(/datum/reagent/consumable/ethanol/hcider = 3, /datum/reagent/consumable/pyre_elementum = 1, /datum/reagent/phosphorus = 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phosphorus is a fair bit harder to obtain and it already has a plant regent with prye elementum and its alot easier to make it with ghetto chem rather then growing glowshrooms. hearthwine is already pretty rare to made compared to other wines.
The scheme I have for trickwine recipes is (Booze, Plant regeant, Some other chemical who's best source is a mob or other biome specific feature)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly. I think its more interesting to get glowshrooms or grind down matches when the alternative is fuel of the weld

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My issue is its WAY easier to get a decent amount of phosphorus via ghetto chem then both of those alternatives.

@rye-rice rye-rice added this pull request to the merge queue Nov 15, 2024
Merged via the queue into shiptest-ss13:master with commit f89f12c Nov 15, 2024
16 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I tried my hand at rewriting the trickwine fluff to feel more... Lore.
This included removing the overtly magical trickwines, rewriting the big
fluff thing, and otherwise adjusting.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Remains to be seen. Please leave your thoughts below. I will disregard
them.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Trickwine fluff has been rewritten
balance: Trickwines have been somewhat nerfed
del: prismwine, forcewine
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Bjarl <[email protected]>
Co-authored-by: Sun-Soaked <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants