Skip to content

Commit

Permalink
Properly marks merge conflicts in map editor (#3974)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Fixes #3965

(re)Adds a merge conflict marker to be used by mapmerge2, additionally
adds an icon for it.


![image](https://github.com/user-attachments/assets/bcfc37e4-a50a-442b-96d0-d1c42419743c)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Merge conflicts can be properly fixed in the map editor now
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: merge conflicts are now properly marked
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
Ical92 authored Jan 15, 2025
1 parent c387ac2 commit c9eb8a1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
6 changes: 6 additions & 0 deletions code/game/objects/merge_conflict_marker.dm
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/obj/merge_conflict_marker
name = "Merge Conflict Marker" // name & desc are set by merge script
desc = "Marks a merge conflict that needs manually resolved. If you're reading this, something has gone very wrong."
icon = 'icons/effects/mapping/mapping_helpers.dmi'
icon_state = "mergeconflict"
layer = ABOVE_ALL_MOB_LAYER
Binary file modified icons/effects/mapping/mapping_helpers.dmi
Binary file not shown.
7 changes: 4 additions & 3 deletions shiptest.dme
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@
#include "code\__HELPERS\game.dm"
#include "code\__HELPERS\generators.dm"
#include "code\__HELPERS\global_lists.dm"
#include "code\__HELPERS\hearted.dm"
#include "code\__HELPERS\heap.dm"
#include "code\__HELPERS\hearted.dm"
#include "code\__HELPERS\icon_smoothing.dm"
#include "code\__HELPERS\icons.dm"
#include "code\__HELPERS\level_traits.dm"
Expand Down Expand Up @@ -1075,6 +1075,7 @@
#include "code\game\objects\buckling.dm"
#include "code\game\objects\empulse.dm"
#include "code\game\objects\items.dm"
#include "code\game\objects\merge_conflict_marker.dm"
#include "code\game\objects\obj_defense.dm"
#include "code\game\objects\objs.dm"
#include "code\game\objects\structures.dm"
Expand Down Expand Up @@ -3302,8 +3303,6 @@
#include "code\modules\ruins\objects_and_mobs\ash_walker_den.dm"
#include "code\modules\ruins\objects_and_mobs\necropolis_gate.dm"
#include "code\modules\ruins\objects_and_mobs\sin_ruins.dm"
#include "code\modules\ruins\rockplanet_ruin_code\mining_base.dm"
#include "code\modules\ruins\sandplanet_ruin_code\cave_base.dm"
#include "code\modules\ruins\objects_and_mobs\generic_hazards\hazard_info.dm"
#include "code\modules\ruins\objects_and_mobs\generic_hazards\hazard_code\_hazard.dm"
#include "code\modules\ruins\objects_and_mobs\generic_hazards\hazard_code\_shutoff.dm"
Expand All @@ -3317,6 +3316,8 @@
#include "code\modules\ruins\objects_and_mobs\generic_hazards\hazards\generic_electrical.dm"
#include "code\modules\ruins\objects_and_mobs\generic_hazards\hazards\radioactive_barrels.dm"
#include "code\modules\ruins\objects_and_mobs\generic_hazards\hazards\water_hazard.dm"
#include "code\modules\ruins\rockplanet_ruin_code\mining_base.dm"
#include "code\modules\ruins\sandplanet_ruin_code\cave_base.dm"
#include "code\modules\ruins\spaceruin_code\bigderelict1.dm"
#include "code\modules\ruins\spaceruin_code\TheDerelict.dm"
#include "code\modules\ruins\wasteplanet_ruin_code\tradepost.dm"
Expand Down

0 comments on commit c9eb8a1

Please sign in to comment.