Skip to content

Commit

Permalink
Fixes wall wardrobes having missing doors (#3958)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Fixes some wall closets having missing doors because of referencing a
removed icon for wardrobes. Instead uses the generic locker door icon.


![image](https://github.com/user-attachments/assets/bc3f97a2-f688-4c2c-aa69-3e6b68b5fa07)
Example on the Colossus 
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Looks better and is less confusing when closed closets aren't missing
doors.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: fixed some wall closets missing doors
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
Ical92 authored Jan 6, 2025
1 parent f47950a commit 954ae78
Show file tree
Hide file tree
Showing 9 changed files with 4 additions and 24 deletions.
4 changes: 1 addition & 3 deletions _maps/RandomRuins/LavaRuins/lavaland_crashed_starwalker.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1123,9 +1123,7 @@
"sw" = (
/obj/effect/turf_decal/siding/wood/end,
/obj/effect/decal/cleanable/dirt/dust,
/obj/structure/closet/wall/directional/east{
icon_door = "grey_wall"
},
/obj/structure/closet/wall/directional/east,
/obj/item/flashlight/lantern{
pixel_x = 8
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,6 @@
dir = 1
},
/obj/structure/closet/wall/directional/north{
icon_door = "orange_wall";
name = "Mining equipment"
},
/obj/item/clothing/glasses/meson,
Expand Down
3 changes: 0 additions & 3 deletions _maps/shuttles/independent/independent_rigger.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,6 @@
dir = 4
},
/obj/structure/closet/wall/directional/east{
icon_door = "white_wall";
name = "medical closet"
},
/obj/item/storage/backpack/satchel/med,
Expand Down Expand Up @@ -1422,7 +1421,6 @@
/area/ship/external)
"sq" = (
/obj/structure/closet/wall/directional/north{
icon_door = "red_wall";
name = "security closet"
},
/obj/item/storage/backpack/security,
Expand Down Expand Up @@ -1596,7 +1594,6 @@
},
/obj/structure/catwalk/over,
/obj/structure/closet/wall/directional/north{
icon_door = "yellow_wall";
name = "engineering closet"
},
/obj/item/storage/backpack/industrial,
Expand Down
1 change: 0 additions & 1 deletion _maps/shuttles/independent/independent_shetland.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -2196,7 +2196,6 @@
"rQ" = (
/obj/effect/turf_decal/corner/opaque/bottlegreen/full,
/obj/structure/closet/wall/directional/west{
icon_door = "white_wall";
name = "medical closet"
},
/obj/item/storage/backpack/satchel/med,
Expand Down
3 changes: 0 additions & 3 deletions _maps/shuttles/inteq/inteq_colossus.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@
/obj/item/clothing/head/soft/inteq,
/obj/item/clothing/head/soft/inteq,
/obj/structure/closet/wall/directional/north{
icon_door = "orange_wall";
name = "uniform closet"
},
/obj/machinery/firealarm/directional/east,
Expand Down Expand Up @@ -2406,7 +2405,6 @@
/obj/item/clothing/shoes/sneakers/black,
/obj/item/clothing/shoes/sneakers/black,
/obj/structure/closet/wall/directional/north{
icon_door = "orange_wall";
name = "uniform closet"
},
/turf/open/floor/plasteel/grimy,
Expand Down Expand Up @@ -3029,7 +3027,6 @@
"GL" = (
/obj/machinery/atmospherics/pipe/layer_manifold/visible,
/obj/structure/closet/wall/directional/east{
icon_door = "yellow_wall";
name = "engineering closet"
},
/obj/structure/catwalk/over/plated_catwalk/dark,
Expand Down
6 changes: 1 addition & 5 deletions _maps/shuttles/inteq/inteq_talos.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -2025,7 +2025,6 @@
/obj/item/clothing/shoes/sneakers/black,
/obj/item/clothing/shoes/sneakers/black,
/obj/structure/closet{
icon_door = "orange";
name = "inteq wardrobe"
},
/obj/effect/decal/cleanable/dirt,
Expand Down Expand Up @@ -2700,9 +2699,7 @@
/obj/structure/catwalk/over/plated_catwalk,
/obj/structure/railing,
/obj/machinery/airalarm/directional/north,
/obj/structure/closet/wall/directional/west{
icon_door = "grey_wall"
},
/obj/structure/closet/wall/directional/west,
/obj/item/radio/headset,
/obj/item/radio/headset,
/obj/item/radio/headset,
Expand Down Expand Up @@ -4730,7 +4727,6 @@
/obj/item/clothing/head/soft/inteq,
/obj/item/clothing/head/soft/inteq,
/obj/structure/closet{
icon_door = "orange";
name = "inteq wardrobe"
},
/obj/machinery/power/apc/auto_name/directional/north,
Expand Down
5 changes: 1 addition & 4 deletions _maps/shuttles/inteq/inteq_vaquero.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,6 @@
/obj/item/clothing/shoes/combat,
/obj/effect/turf_decal/hardline_small/right,
/obj/structure/closet/wall/directional/east{
icon_door = "yellow_wall";
name = "engineering closet"
},
/obj/machinery/atmospherics/pipe/manifold/scrubbers/hidden/layer4{
Expand Down Expand Up @@ -1770,9 +1769,7 @@
/turf/open/floor/plasteel/dark,
/area/ship/security)
"Bu" = (
/obj/structure/closet/wall/directional/north{
icon_door = "grey_wall"
},
/obj/structure/closet/wall/directional/north,
/obj/structure/cable{
icon_state = "0-2"
},
Expand Down
4 changes: 1 addition & 3 deletions _maps/shuttles/pirate/pirate_libertatia.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -888,9 +888,7 @@
/obj/item/clothing/under/costume/sailor,
/obj/item/clothing/under/costume/sailor,
/obj/item/clothing/under/costume/sailor,
/obj/structure/closet/wall/directional/east{
icon_door = "grey_wall"
},
/obj/structure/closet/wall/directional/east,
/turf/open/floor/pod/light,
/area/ship/crew)
"By" = (
Expand Down
1 change: 0 additions & 1 deletion _maps/shuttles/syndicate/syndicate_gorlex_komodo.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1431,7 +1431,6 @@
/obj/item/mining_scanner,
/obj/item/mining_scanner,
/obj/structure/closet/wall/directional/south{
icon_door = "orange_wall";
name = "Mining equipment"
},
/obj/item/gps/mining,
Expand Down

0 comments on commit 954ae78

Please sign in to comment.