This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

readme fix: Shipment.all – pass parameters as a hash #152

Open

Jonathan-Jacob wants to merge 1 commit into shipcloud:master from Jonathan-Jacob:update-docs

Jonathan-Jacob commented Aug 7, 2024

Replaced this

Shipcloud::Shipment.all(
  carrier: 'ups',
  per_page: 25,
  page: 2
)

with this

Shipcloud::Shipment.all({
  carrier: 'ups',
  per_page: 25,
  page: 2
})

since otherwise you will get an ArgumentError


          readme fix: Shipment.all

2d6d31a

Author

Jonathan-Jacob commented Aug 7, 2024

Failed checks should be irrelevant since this is only a PR for a README change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet